Urlencode branch name #1275
Merged
Urlencode branch name #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
added
[Type] Bug
|
Great find @bgrgicak, thank you! |
dmsnell
reviewed
Apr 19, 2024
| @@ -50,7 +50,7 @@ public function streamFromGithubPR($organization, $repo, $pr, $workflow_name, $a | |||
| if (!$prDetails) { | |||
| throw new ApiException('invalid_pr_number'); | |||
| } | |||
| $branchName = $prDetails->head->ref; | |||
| $branchName = urlencode($prDetails->head->ref); | |||
| $ciRuns = $this->gitHubRequest("https://api.github.com/repos/$organization/$repo/actions/runs?branch=$branchName")['body']; | |||
There was a problem hiding this comment.
we can also rely on http_build_query() to handle this for us.
$query = http_build_query( [ 'branch' => $prDetais->head->ref ], '', null, PHP_QUERY_RFC3986 );
$url = "https://...?{$query}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1260
What is this PR doing?
It ensures that the WordPress pull request test page can fetch the correct PR data.
What problem is it solving?
When a branch name has special characters like #, GitHub API requests may not work as intended.
How is the problem addressed?
By encoding the branch name.
Testing Instructions
http://localhost:8787) to the start of this url