Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support uploads to paths different than /wp-content/uploads #49

Closed
adamziel opened this issue Oct 17, 2022 · 1 comment
Closed

Support uploads to paths different than /wp-content/uploads #49

adamziel opened this issue Oct 17, 2022 · 1 comment
Labels
[Priority] Low

Comments

@adamziel
Copy link
Collaborator

adamziel commented Oct 17, 2022 •
edited

#48 Introduced a support for file uploads. Unfortunately it introduces an assumption that all requests to /wp-content/uploads/* should be resolved from the WASM filesystem, and all other non-PHP requests should be resolved from the server where wordpress-wasm is hosted.

Let's relax that constraint and correctly serve the static files from either the server or the WASM filesystem regardless of their path.
@adamziel adamziel mentioned this issue Oct 17, 2022
Closed
@adamziel adamziel changed the title [Browser] Support uploads to paths different than /wp-content/uploads Support uploads to paths different than /wp-content/uploads Oct 22, 2022
eruizdechavez pushed a commit to eruizdechavez/wordpress-playground that referenced this issue Sep 20, 2023
@danielbachhuber
VS Code: Update to use latest wp-now internals (WordPress#49)
8f89afa 
Fixes WordPress/playground-tools#4

## What?

Updates the VS Code Extension to work with the latest implementation of
`wp-now`.

## Why?

It's broken otherwise.

## How?

<!-- How is your PR addressing the issue at hand? What are the
implementation details? -->

## Testing Instructions

1. Follow the new CONTRIBUTING instructions to run the VS Code Extension
locally.
2. Verify 'Start server' launches a new WordPress Playground.
3. Verify it's possible to switch PHP and WordPress versions.

<!-- Please include step by step instructions on how to test this PR.
-->
<!-- 1. Check out the branch. -->
<!-- 2. Run a command. -->
<!-- 3. etc. -->
@adamziel adamziel mentioned this issue Oct 4, 2023
Closed
10 tasks
@adamziel
Copy link
Collaborator Author

Solved in #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Priority] Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamziel