Support file uploads #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
PHP handles file uploads by referring to the
$_FILES
superglobal variable. This PR prepopulates it with any files attached to the request.Related to #34
The data flow:
$_FILES
data format before dispatching the request. Thetmp_name
key is populated by taking the raw bytes from the JSFile
and storing them in a temporary file in the PHP filesystem.Importantly, the information stored in
$_FILES
are subject to safety checks. To quote the PHP documentation at https://www.php.net/manual/en/function.is-uploaded-file.php:We don’t run the PHP request machinery in WASM, so is_uploaded_file() fails by default. This commit circumvents the problem by introducing three new C functions:
They are used to tell PHP which uploads are legitimate and should pass the safety checks.
Caveats
/wp-content/uploads
– it’s a limiting assumption that will need to be revisited sooner than later.