Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iconv to the kitchen-sink bundle #685

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Add iconv to the kitchen-sink bundle #685

merged 3 commits into from
Oct 12, 2023

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Oct 12, 2023 •
edited
Loading

What is this PR doing?

Includes the iconv PHP extension in the kitchen-sink extension bundle, see #681

This work was done by @seanmorris in Pull Request #639, I'm only extracting it to a separate PR to ship it faster.

CleanShot 2023-10-12 at 11 13 59@2x

Test plan

  1. In Playground, go to /phpinfo.php
  2. Confirm the iconv extension is not loaded by default
  3. Go to the customization modal, check "load additional PHP extensions"
  4. Confirm the iconv extension is now listed on /phpinfo.php

@adamziel adamziel self-assigned this Oct 12, 2023
@adamziel adamziel merged commit 772386c into trunk Oct 12, 2023
4 checks passed
@adamziel adamziel deleted the add/iconv branch October 12, 2023 10:05
@adamziel adamziel mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adamziel adamziel

Labels
[Feature] PHP.wasm [Type] Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamziel