Add php.defineConstant() public API #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
file. However, the setPhpIniEntry() was called after the initial
php.run() which made it noop. This broke the networking support
merged in #724.
This commit solves that by moving the setPhpIniEntry right after
the PHP module is initialized. I am not super happy about exporting
the virtualized file path from the blueprints module – let's
revisit that in the future.
adamziel
added
[Type] Bug
adamziel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#738 introduced a change that made all WordPress constants be defined by including a "virtualized" wp-consts.php file. However, the required
setPhpIniEntry()call was sometimes happening after the initialphp.run()which made it noop. This broke the networking support merged in #724.This commit solves that by exposing a new
php.defineConstant()API that handles the file virtualization. I'm not super happy about virtualizing files so let's revisit that in the future, see #750.