Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add php.defineConstant() public API #748

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Add php.defineConstant() public API #748

merged 8 commits into from
Nov 17, 2023

Commits on Nov 15, 2023

  1. Run setPhpIniEntry('auto_prepend_file' before the first php.run() 

         file. However, the setPhpIniEntry() was called after the initial
     php.run() which made it noop. This broke the networking support
     merged in #724.

     This commit solves that by moving the setPhpIniEntry right after
     the PHP module is initialized. I am not super happy about exporting
     the virtualized file path from the blueprints module – let's
     revisit that in the future.
    @adamziel
    adamziel committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    126d4cb View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Remove a comment

    @adamziel
    adamziel committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    99fb557 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into fix/set-php-ini-entry-call

    @adamziel
    adamziel committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3549e72 View commit details
    Browse the repository at this point in the history

  3. Resolve paths.ts conflict

    @adamziel
    adamziel committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c1ca80b View commit details
    Browse the repository at this point in the history

  4. Expose a new defineConstant() PHP SAPI method to define PHP constants

    @adamziel
    adamziel committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    829db4d View commit details
    Browse the repository at this point in the history

  5. Adjust types

    @adamziel
    adamziel committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f4e1a85 View commit details
    Browse the repository at this point in the history

  6. Fix types

    @adamziel
    adamziel committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b1097da View commit details
    Browse the repository at this point in the history

  7. Check if consts.json exist

    @adamziel
    adamziel committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c25b02c View commit details
    Browse the repository at this point in the history