-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Plugin single links and buttons missing hover states #263
Comments
It looks like these are not using the correct button styles — but if the old
Yeah, this is a bug.
We recently had a discussion about button styles, and from my research and understanding of the guidelines, the fact that the mouse cursor changes from default to pointer is enough of a change — although by default, the blue buttons should get slightly darker on hover. https://wordpress.org/download/ shows these buttons the way they're supposed to work. |
Links look good 👍 👍 |
Agreed, links look good and removing the buttons also increases the prominence of the Download and Live Preview (for those plugins that have it) buttons. |
…ks and left align. See: #263 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13585 74240141-8908-4e6f-9713-ba540dce6ec7
See: #263 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13586 74240141-8908-4e6f-9713-ba540dce6ec7
See: #263 Props: alh0319 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13617 74240141-8908-4e6f-9713-ba540dce6ec7
…omponents that need further thought. See: #263 Props: alh0319, ryelle -This line, and those below, will be ignored-- M wporg-plugins-2024/client/components/plugin/_favorite-button.scss M wporg-plugins-2024/client/components/plugin/style.scss M wporg-plugins-2024/client/components/widget-area/_widgets-meta.scss D wporg-plugins-2024/client/styles/objects/_links.scss M wporg-plugins-2024/client/styles/objects/_objects.scss M wporg-plugins-2024/css/style-rtl.css M wporg-plugins-2024/css/style.css git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13680 74240141-8908-4e6f-9713-ba540dce6ec7
I made underlined as the default for the theme and updated button states. If any components are missing links or inconsistent, let's open up new tickets for those specific changes. Thanks! |
On the plugin single page (Gutenberg plugin test page), the buttons and links are all missing hover states.
On hover, text links should have the underline removed.
On hover, buttons need a design change that either contrasts with the default state or is other wise visually distinct (switching from solid to underline or adding an icon, for example).
The text was updated successfully, but these errors were encountered: