This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Implement Prettier #118
Merged
Implement Prettier #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ntwb
reviewed
May 7, 2020
|
Looking good, this is what I'm seeing: > wp-scripts lint-js
/Users/netweb/Code/WordPress/wp-autoupdates/js/wp-autoupdates.js
37:5 error 'data' is never reassigned. Use 'const' instead prefer-const
45:13 error 'ajaxurl' is not defined no-undef
117:23 error 'response' is defined but never used no-unused-vars
143:8 error 'plugin' is never reassigned. Use 'const' instead prefer-const
152:6 error 'jQuery' is not defined no-undef
✖ 5 problems (5 errors, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.
|
|
@ntwb, added a few updates, coming back clean now. |
ntwb
approved these changes
May 7, 2020
|
Thanks @whyisjake 👍 |
pbiron
suggested changes
May 7, 2020
whyisjake
force-pushed
the
whyisjake-coding-standards
branch
from
04f3dff
to
c091550
Compare
whyisjake
added a commit
that referenced
this pull request
May 9, 2020
whyisjake
force-pushed
the
whyisjake-coding-standards
branch
from
8e8ebd9
to
77b4698
Compare
pbiron
approved these changes
May 9, 2020
ntwb
approved these changes
May 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fork of the work that @ntwb did in #111. I extended a few things and then brought the changes over from master.