Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include require statements #111

Merged
merged 1 commit into from Sep 9, 2022
Merged

Include require statements #111

merged 1 commit into from Sep 9, 2022

Conversation

dingo-d
Copy link
Member

@dingo-d dingo-d commented Aug 20, 2022

This PR depends on #110. Once that is merged, this PR should be rebased to the master branch.

The PR adds rules about the include/require statements and is the continuation of the additions of 'modern' PHP code in the WordPress PHP Coding Standards handbook based on the make post by Juliette Reinders Folmer.

@dingo-d dingo-d self-assigned this Aug 20, 2022
@dingo-d dingo-d force-pushed the include-require-expressions branch from 9c47738 to 40a4218 Compare August 26, 2022 10:09
@dingo-d dingo-d marked this pull request as ready for review August 26, 2022 10:09
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some inline notes.

wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
wordpress-coding-standards/php.md Outdated Show resolved Hide resolved
@dingo-d dingo-d force-pushed the include-require-expressions branch from 4ff62fa to 8c97407 Compare August 28, 2022 15:28
@dingo-d dingo-d requested a review from jrfnl August 28, 2022 15:28
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
Co-authored-by: Gary Jones <github@garyjones.io>
Copy link
Member

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dingo-d
Copy link
Member Author

dingo-d commented Sep 6, 2022

@jrfnl Mind giving this another check, and merging if it's ok?

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dingo-d !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants