Fix related section collapsing issue

[renintw]

Fixes #142

Originally, the Uses table in the Related section would be collapsed and show 0 records even though there are actually some records existing. After the fix, if the amount of records <= 5, it would never be collapsed.

Reason for changing from min to max

The return value of split_uses_by_frequent_funcs is infrequent_count, and the purpose of the function is to Rearrange the results of get_uses() so that frequent functions are pushed to the bottom. I'm not 100% sure why we want to show infrequently used functions to users first here (maybe I misunderstood the real purpose of the function), but according to the function's goal and its doc comment, I'm thinking that we can change from min to max here so that we can show as many infrequently used functions to users as possible.

Or if we still want it to show five records at most, we can specify the least records to show as well.
Perhaps:

$uses_to_show = min( $uses_to_show, max( split_uses_by_frequent_funcs( $uses->posts ), $least_uses_to_show) );

[StevenDufresne]

I can't speak to the particulars of frequency but the main goal was to avoid a very long list of functions.

[ryelle]

I'm not 100% sure why we want to show infrequently used functions to users first here

You can see the original PR #37 — the purpose was to avoid always showing the same functions, ex __() or apply_filters for all functions. By showing rarely-used functions, the idea is that the functions shown are more relevant to the current page.

I think I prefer adding a min value to show (maybe 2?), rather than switching the min to max, that way we always hide after 5 items. /reference/functions/_wp_dashboard_recent_comments_row/ is a good test case with many rarely-used functions. On this PR, it shows 11 items before hiding the remaining 7.

[renintw]

I think I prefer adding a min value to show (maybe 2?), rather than switching the min to max, that way we always hide after 5 items. /reference/functions/_wp_dashboard_recent_comments_row/ is a good test case with many rarely-used functions. On this PR, it shows 11 items before hiding the remaining 7.

I prefer this as well. I've pushed a new commit for it, and in it I've removed the comment (ie the cutoff point for show/hide). as it's not used as the cutoff point. Thanks for sharing the test case!

[ryelle]

Looks good 👍🏻