Add hreflang link tags #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made a couple of quick edits so it runs in local testing without GlotPress installed.
tellyworth
commented
Aug 8, 2022
| return strcasecmp( $a->hreflang, $b->hreflang ); | ||
| } ); | ||
|
|
||
| wp_cache_set( 'local-sites', $sites, 'locale-associations' ); |
There was a problem hiding this comment.
I thought about making the cache_set conditional on count( $sites ) > 2 so my local testing bypass can't poison the cache in production if it somehow executed the wrong code path.
dd32
reviewed
Aug 9, 2022
dd32
reviewed
Aug 9, 2022
|
|
||
| foreach ( $sites as $site ) { | ||
| $url = sprintf( | ||
| 'https://%swordpress.org%s', |
There was a problem hiding this comment.
I guess we don't really care that this will reference wordpress.org as the hreflang when it's being used locally, so I see no problem keeping the production domain here.
Thanks @dd32
|
I think this is good to go now but let's wait till after the DC review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a straight port of the
hreflang_link_attributesfunction from thewporgtheme.I made a couple of quick edits so it runs in local testing without GlotPress installed.
Fixes #43.
Props @dd32.
How to test the changes in this Pull Request:
<link rel="alternate" href="..." hreflang="..">elements.