Prevent scrolling behind search modal #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously it was white below the fold b/c the modal content doesn't fill the screen and the bg gets inherited from `body`
previously it was at `top: 0` from the start of `<html>` instead of the start of the viewport.
|
This is still a WIP. I found a few edge cases after applying the hotfix and fixed those, but there's at least 1 more that I'm working on. |
previously in safari the content bg color would change to grey
… way, but this olso cause problems gap removed under 600px, and at tablet breakpoint, but still exists between the two
This was referenced Mar 31, 2023
|
I tried another approach in #382 and that seems more promising at the moment. I'll keep this open until that's finalized, though. |
|
#392 will fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371
Closes #382