Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent scrolling behind search modal #381

Closed
wants to merge 8 commits into from
Closed

Prevent scrolling behind search modal #381

wants to merge 8 commits into from

Commits on Mar 30, 2023

  1. apply upstream hotfix

    @iandunn
    iandunn committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    bb09c78 View commit details
    Browse the repository at this point in the history

  2. fill in bg color when modal open and admin bar not present 

    previously it was white below the fold b/c the modal content doesn't fill the screen and the bg gets inherited from `body`
    @iandunn
    iandunn committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    4167212 View commit details
    Browse the repository at this point in the history

  3. position admin bar at top when showing and search modal open 

    previously it was at `top: 0` from the start of `<html>` instead of the start of the viewport.
    @iandunn
    iandunn committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    f8cc7a8 View commit details
    Browse the repository at this point in the history

  4. dont want fixed on desktop because we dont style it like a modal

    @iandunn
    iandunn committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    f24f8b1 View commit details
    Browse the repository at this point in the history

  5. move to permanent location

    @iandunn
    iandunn committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    052611d View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. turn off dark background for tablet+ breakpoints 

    previously in safari the content bg color would change to grey
    @iandunn
    iandunn committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    fc7a3fe View commit details
    Browse the repository at this point in the history

  2. move pos:static to better location

    @iandunn
    iandunn committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    8771c61 View commit details
    Browse the repository at this point in the history

  3. revert margin->padding commit b/c causes problems, try to solve other… 

    … way, but this olso cause problems

gap removed under 600px, and at tablet breakpoint, but still exists between the two
    @iandunn
    iandunn committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    f9c34b9 View commit details
    Browse the repository at this point in the history