Replace props spreading with explicit attributes to avoid warnings #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unintentionally passing invalid HTML attributes results in console warnings like these: > Warning: React does not recognize the `setInputs` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `setinputs` instead. If you accidentally passed it from a parent component, remove it from the DOM element. > Warning: Unknown event handler property `onComplete`. It will be ignored.
iandunn
force-pushed
the
input-props-spread
branch
from
ec8d0d0
to
61cd536
Compare
renintw
approved these changes
May 15, 2023
renintw
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152
This adds the necessary parameters explicitly, instead of spreading
props.Related #127