Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Radio into a Compound Component #1196

Closed
2 tasks done
Tracked by #1926
, #1543
...
myvuuu opened this issue Jul 30, 2021 · 1 comment · Fixed by #1944
Closed
2 tasks done
Tracked by #1926
, #1543
...

Convert Radio into a Compound Component #1196

myvuuu opened this issue Jul 30, 2021 · 1 comment · Fixed by #1944
Assignees
@jamesfan @mannycarrera4
Labels
9.x
Milestone
9.1.0

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Jul 30, 2021 •
edited by jaclynjessup
Loading

🚀 Feature Proposal

Convert Radio into a compound component.

Tasks
Beta Give feedback
  1. Basic Radio: keyboard focus loss onChange #2052
    bug
  2. Alert and Error radio group examples cannot be operated with the keyboard #2196
    bug
@myvuuu myvuuu added the enhancement New feature or request label Jul 30, 2021
@myvuuu myvuuu added the 6.x label Aug 12, 2021
@myvuuu myvuuu mentioned this issue Aug 16, 2021
Closed
@myvuuu myvuuu removed the 6.x label Sep 7, 2021
@myvuuu myvuuu added the p:2 label Sep 16, 2021
@myvuuu myvuuu added good first issue Good for newcomers help wanted Good for experienced contributors and removed good first issue Good for newcomers labels Nov 30, 2021
@myvuuu myvuuu added the 7.x label Dec 9, 2021
@myvuuu
Copy link
Collaborator Author

myvuuu commented Dec 9, 2021

Should consider fixing #1067 as part of this issue

@myvuuu myvuuu added 7.x and removed 7.x labels Feb 25, 2022
@myvuuu myvuuu modified the milestones: 7.0.0, 8.0.0 Mar 10, 2022
@myvuuu myvuuu modified the milestones: 8.0.0, 7.0.0 Mar 24, 2022
@willklein willklein removed the help wanted Good for experienced contributors label Mar 24, 2022
@myvuuu myvuuu removed this from the 7.0.0 milestone Jul 12, 2022
@jaclynjessup jaclynjessup removed the p:2 label Aug 5, 2022
@jaclynjessup jaclynjessup removed the enhancement New feature or request label Aug 5, 2022
@jaclynjessup jaclynjessup mentioned this issue Nov 21, 2022
Open
1 task
@willklein willklein mentioned this issue Nov 29, 2022
Closed
18 tasks
@RayRedGoose RayRedGoose mentioned this issue Dec 19, 2022
Closed
@jaclynjessup jaclynjessup added 9.x and removed 7.x labels Mar 30, 2023
@jaclynjessup jaclynjessup linked a pull request Apr 6, 2023 that will close this issue
feat: Add new Radio compound component #1944
Merged
6 tasks
@jaclynjessup jaclynjessup added this to the 9.1.0 milestone May 17, 2023
@jamesfan jamesfan self-assigned this Jun 26, 2023
@jamesfan jamesfan mentioned this issue Jul 6, 2023
Merged
6 tasks
alanbsmith pushed a commit that referenced this issue Jul 7, 2023
@mani11 @mannycarrera4
@jamesfan @RayRedGoose
feat: Add new Radio compound component (#1944)
ca8a1de 
Fixes: #1196

Adds a new compound Radio component to the Preview package.

[category:Components]

Release Note:
We've created a new Radio compound component in the Preview package. This component matches our pattern of providing access to lower-level elements and allows for more flexibility.

Co-authored-by: Manleen Bhatia <manleen.bhatia@workday.com>
Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Co-authored-by: @mannycarrera4 <mannycarrera4@users.noreply.github.com>
Co-authored-by: @jamesfan <james@somewhatstrange.com>
Co-authored-by: @RayRedGoose <48605821+RayRedGoose@users.noreply.github.com>
@github-actions github-actions bot closed this as completed Jul 7, 2023
@myvuuu myvuuu mentioned this issue Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesfan jamesfan

@mannycarrera4 mannycarrera4

Labels
9.x
Projects
Canvas Kit
Status: ✅ Done
Canvas Kit Milestone Planning
Status: Done
Milestone
9.1.0
Development

Successfully merging a pull request may close this issue.

feat: Add new Radio compound component mani11/canvas-kit
6 participants
@jamesfan @willklein @mani11 @mannycarrera4 @jaclynjessup @myvuuu