Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of Menu in Preview #1993

Closed
3 tasks
myvuuu opened this issue Jan 18, 2023 · 1 comment · Fixed by #2247
Closed
3 tasks

Removal of Menu in Preview #1993

myvuuu opened this issue Jan 18, 2023 · 1 comment · Fixed by #2247
Assignees
@josh-bagwell
Labels
10.x
Milestone
10.0.0

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Jan 18, 2023 •
edited by josh-bagwell
Loading

💡 Suggestion

Remove Menu in Preview. A newer version is already available in Main

Acceptance Criteria

  • Remove the component
  • Remove the tests
  • Update the upgrade guide

Note from moving to v10 from v9

  • Wait til v10 for removal of Menu and MenuItem in preview
  • Get teams to move to Menu in main before it is removed in v10 by:
  • Giving teams the Migration guide and code sandbox example to cover examples
  • Support as we can
@myvuuu myvuuu added the 9.x label Jan 18, 2023
@myvuuu myvuuu added this to the 9.0.0 milestone Jan 18, 2023
@alanbsmith
Copy link
Member

Alan will look at who is using the preview menu so we can give advanced notice

@josh-bagwell josh-bagwell self-assigned this Feb 1, 2023
@josh-bagwell josh-bagwell mentioned this issue Feb 27, 2023
Closed
1 task
@josh-bagwell josh-bagwell changed the title Hard Deprecate Menu in Preview Removal of Menu in Preview Feb 28, 2023
@alanbsmith alanbsmith linked a pull request Mar 1, 2023 that will close this issue
chore: Removal of Menu from Preview #2055
Closed
1 task
@josh-bagwell josh-bagwell mentioned this issue Mar 7, 2023
Closed
1 task
@josh-bagwell josh-bagwell linked a pull request Mar 7, 2023 that will close this issue
chore: Removed Menu in Preview #2070
Closed
1 task
@github-actions github-actions bot closed this as completed Mar 7, 2023
@josh-bagwell josh-bagwell removed a link to a pull request Mar 7, 2023
chore: Removal of Menu from Preview #2055
Closed
1 task
@josh-bagwell josh-bagwell reopened this Mar 7, 2023
@josh-bagwell josh-bagwell added the blocked This issue is waiting for one or more issues to be closed/resolved. label Mar 9, 2023
@jaclynjessup jaclynjessup modified the milestones: 9.0.0, 10.0.0 Mar 14, 2023
@josh-bagwell josh-bagwell added 10.x and removed 9.x labels Mar 14, 2023
@josh-bagwell josh-bagwell reopened this Mar 14, 2023
@jaclynjessup jaclynjessup mentioned this issue May 12, 2023
Closed
@jaclynjessup jaclynjessup removed the blocked This issue is waiting for one or more issues to be closed/resolved. label May 12, 2023
@josh-bagwell josh-bagwell mentioned this issue Jun 7, 2023
Merged
1 task
@josh-bagwell josh-bagwell linked a pull request Jun 7, 2023 that will close this issue
feat: Remove Menu Preview #2247
Merged
1 task
@josh-bagwell josh-bagwell removed a link to a pull request Jun 7, 2023
chore: Removed Menu in Preview #2070
Closed
1 task
alanbsmith pushed a commit that referenced this issue Jun 16, 2023
@josh-bagwell
feat!: Remove Menu Preview (#2247)
7da0817 
Removal of the `DeprecatedMenu` and `DeprecatedMenuItem` component in Preview.

Fixes: #1993  

A compound component version is already in Main.

[category:Components]

Release Note:
This will not involve a codemod since the API has too many differences between the component being removed in Preview and the component in Main.

### BREAKING CHANGES
To move from the Menu component in Preview to the Menu compound component in Main, please read [this discussion](#2063).

Also, see [this](https://codesandbox.io/s/deprecatedmenu-and-menu-migration-gwi1ov) codesandbox that shows the differences between DeprecatedMenu and the Menu compound component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josh-bagwell josh-bagwell

Labels
10.x
Projects
Canvas Kit
Status: ✅ Done
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

feat: Remove Menu Preview josh-bagwell/canvas-kit
4 participants
@alanbsmith @jaclynjessup @josh-bagwell @myvuuu