-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove Menu Preview #2247
feat: Remove Menu Preview #2247
Conversation
1 flaky tests on run #5825 ↗︎
Details:
cypress/integration/Autocomplete.spec.ts • 1 flaky testThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
I think the code is fine, but are we ready to remove the preview menu? |
This PR will be merged after docs have been reviewed (I'm on it now). #2259 will be completed prior to the v10 release to add support for grouping to the Menu in Main. This will give the Menu in Main complete feature parity with the Menu in Preview which is being removed in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good 👍
Summary
Removal of the
DeprecatedMenu
andDeprecatedMenuItem
component in Preview.Fixes: #1993
A compound component version is already in Main.
Release Category
Components
Release Note
This will not involve a codemod since the API has too many differences between the component being removed in Preview and the component in Main.
BREAKING CHANGES
To move from the Menu component in Preview to the Menu compound component in Main, please read this discussion.
Also, see this codesandbox that shows the differences between DeprecatedMenu and the Menu compound component.
For the Reviewer
There are some visual changes moving from
DeprecatedMenu
andDeprecatedMenuItem
toMenu
.StyledMenuItem
is now being exported to take the place ofDeprecatedMenuItem
.Where Should the Reviewer Start?
/modules/preview-react/menu
/modules/docs/mdx/10.0-UPGRADE_GUIDE