Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Menu Preview #2247

Merged

Conversation

josh-bagwell
Copy link
Contributor

@josh-bagwell josh-bagwell commented Jun 7, 2023

Summary

Removal of the DeprecatedMenu and DeprecatedMenuItem component in Preview.

Fixes: #1993

A compound component version is already in Main.

Release Category

Components

Release Note

This will not involve a codemod since the API has too many differences between the component being removed in Preview and the component in Main.

BREAKING CHANGES

To move from the Menu component in Preview to the Menu compound component in Main, please read this discussion.

Also, see this codesandbox that shows the differences between DeprecatedMenu and the Menu compound component.


For the Reviewer

There are some visual changes moving from DeprecatedMenu and DeprecatedMenuItem to Menu.

StyledMenuItem is now being exported to take the place of DeprecatedMenuItem.

  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

/modules/preview-react/menu
/modules/docs/mdx/10.0-UPGRADE_GUIDE

@josh-bagwell josh-bagwell linked an issue Jun 7, 2023 that may be closed by this pull request
3 tasks
@josh-bagwell josh-bagwell self-assigned this Jun 7, 2023
@cypress
Copy link

cypress bot commented Jun 7, 2023

1 flaky tests on run #5825 ↗︎

0 897 2 0 Flakiness 1

Details:

Merge d9f7968 into aec7d64...
Project: canvas-kit Commit: bea3676e50 ℹ️
Status: Passed Duration: 07:37 💡
Started: Jun 8, 2023 7:39 PM Ended: Jun 8, 2023 7:47 PM
Flakiness  cypress/integration/Autocomplete.spec.ts • 1 flaky test

View Output Video

Test Artifacts
... > when a value is entered > when down arrow key is pressed > when the user presses the enter key > when the use hits the "2" key > should change the filtered results Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@josh-bagwell josh-bagwell marked this pull request as ready for review June 8, 2023 22:32
@josh-bagwell josh-bagwell added ready for review Code is ready for review 10.x labels Jun 8, 2023
@github-actions github-actions bot requested a review from willklein June 8, 2023 22:34
@alanbsmith alanbsmith removed the ready for review Code is ready for review label Jun 9, 2023
@alanbsmith alanbsmith removed the request for review from willklein June 9, 2023 17:44
@alanbsmith alanbsmith added the ready for review Code is ready for review label Jun 9, 2023
@NicholasBoll
Copy link
Member

I think the code is fine, but are we ready to remove the preview menu?

@josh-bagwell josh-bagwell added on hold PR is on hold until further notice and removed on hold PR is on hold until further notice labels Jun 14, 2023
@jamesfan jamesfan self-assigned this Jun 16, 2023
@jamesfan
Copy link
Member

This PR will be merged after docs have been reviewed (I'm on it now).

#2259 will be completed prior to the v10 release to add support for grouping to the Menu in Main. This will give the Menu in Main complete feature parity with the Menu in Preview which is being removed in this PR.

Copy link
Member

@jamesfan jamesfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good 👍

@jamesfan jamesfan added automerge and removed ready for review Code is ready for review labels Jun 16, 2023
@alanbsmith alanbsmith merged commit 7da0817 into Workday:prerelease/major Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of Menu in Preview
4 participants