Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CountBadge Styles Refactor #2397

Closed
jaclynjessup opened this issue Nov 15, 2023 · 0 comments · Fixed by #2442
Closed

CountBadge Styles Refactor #2397

jaclynjessup opened this issue Nov 15, 2023 · 0 comments · Fixed by #2442
Labels
11.x
Milestone
11.0.0

Comments

@jaclynjessup
Copy link
Member

jaclynjessup commented Nov 15, 2023 •
edited by alanbsmith
Loading

🚀 Feature Proposal

Badge style refactor is needed with the new cs prop that has been created. We will need to update the Badge to use the new system level tokens via CSS variables from the CanvasProvider.

Acceptance Criteria:

  • All Canvas Badge variants are tied to CSS variables
  • Update the v11 upgrade guide

Motivation

This will utilize the new cs prop and we now have access to new css properties
@jaclynjessup jaclynjessup added this to the 11.0.0 milestone Nov 15, 2023
@jaclynjessup jaclynjessup changed the title Text Input Styles Refactor Badge Styles Refactor Nov 17, 2023
@alanbsmith alanbsmith changed the title Badge Styles Refactor CountBadge Styles Refactor Dec 4, 2023
@alanbsmith alanbsmith mentioned this issue Dec 4, 2023
Merged
10 tasks
alanbsmith added a commit that referenced this issue Dec 19, 2023
@alanbsmith
chore: Update CountBadge styles (#2442)
75eb2cf 
Resolves: #2397

This PR:

- Rebuilds `CountBadge` to use `createComponent` and our new styling utils
- Updates related tests
- Updates related docs
- Updates V11 upgrade guide

[category:Components]

Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
alanbsmith added a commit to alanbsmith/canvas-kit that referenced this issue Feb 6, 2024
@alanbsmith
chore: Update CountBadge styles (Workday#2442)
2b0d3ad 
Resolves: Workday#2397

This PR:

- Rebuilds `CountBadge` to use `createComponent` and our new styling utils
- Updates related tests
- Updates related docs
- Updates V11 upgrade guide

[category:Components]

Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
11.x
Projects
Canvas Kit
Status: ✅ Done
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

chore: Update CountBadge styles alanbsmith/canvas-kit
1 participant
@jaclynjessup