chore: Update CountBadge styles #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanbsmith
force-pushed
the
ISSUE-2397
branch
from
bf83f96
to
942873a
Compare
1 flaky test on run #6596 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > when the "Delete" button has focus and the tab key is pressed > should hide the popup |
Screenshots
Video
|
|
Review all test suite changes for PR #2442 ↗︎
alanbsmith
added
ready for review
| display: 'inline-flex', | ||
| fontFamily: system.fontFamily.default, | ||
| fontSize: system.fontSize.subtext.medium, | ||
| fontWeight: 700, // should use system.fontWeight.bold |
There was a problem hiding this comment.
do we have an issue created for fontStyles not being recognized by create Styles?
mannycarrera4
requested changes
Dec 19, 2023
mannycarrera4
approved these changes
Dec 19, 2023
alanbsmith
added a commit
to alanbsmith/canvas-kit
that referenced
this pull request
Feb 6, 2024
Resolves: Workday#2397 This PR: - Rebuilds `CountBadge` to use `createComponent` and our new styling utils - Updates related tests - Updates related docs - Updates V11 upgrade guide [category:Components] Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
10 tasks
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #2397
This PR:
CountBadgeto usecreateComponentand our new styling utilsRelease Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)