Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MergeStyles does not accept grid styles #2758

Closed
josh-bagwell opened this issue May 28, 2024 · 0 comments · Fixed by #2759
Closed

MergeStyles does not accept grid styles #2758

josh-bagwell opened this issue May 28, 2024 · 0 comments · Fixed by #2759
Labels
11.x bug Something isn't working

Comments

@josh-bagwell
Copy link
Contributor

🐛 Bug Report

Table Row was not accepting style props on grid styles specifically. This was an issue as style props from grid styles would be applied directly to the HTML element and not to the css for the component.

To Reproduce

Add grid specific style props (i.e. gridTemplateColumns, gridGap, gridTemplateAreas, etc.) to <Table.Row/>. This will not overwrite existing stencil styles and will instead be applied to the HTML element itself.

Expected Behavior

Style props for grid styles should overwrite the stencil styles.

Actual Results

Styles props do not overwrite existing stencil styles and will instead be applied to the HTML element itself.

@josh-bagwell josh-bagwell added bug Something isn't working 11.x labels May 28, 2024
alanbsmith pushed a commit that referenced this issue May 28, 2024
Fixes: #2758  

`mergeStyles` utility now merges grid styles that were used as styleprops and overwrites existing styles as intended.

[category:Components]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11.x bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant