Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Component Style Updates from Audit #2485

Merged
merged 28 commits into from
Jan 17, 2024

Conversation

josh-bagwell
Copy link
Contributor

Summary

Addresses discrepancies that were found in component audit between Figma and CK.

Fixes: #2477

Needed to make style update to better align with Figma and design.

Release Category

Components

Release Note

Style updates will have minor visual changes.


Checklist

Where Should the Reviewer Start?

/modules/docs/mdx/11.0-UPGRADE-GUIDE.mdx

@josh-bagwell josh-bagwell changed the title Component Style Updates from Audit feat: Component Style Updates from Audit Dec 20, 2023
Copy link

cypress bot commented Dec 20, 2023

1 flaky test on run #6710 ↗︎

0 964 3 0 Flakiness 1

Details:

Merge 99dd2c1 into 3c7bc93...
Project: canvas-kit Commit: 222e0dadfa ℹ️
Status: Passed Duration: 05:08 💡
Started: Jan 17, 2024 3:47 PM Ended: Jan 17, 2024 3:52 PM
Flakiness  cypress/integration/Popup.spec.ts • 1 flaky test

View Output Video

Test Artifacts
... > when the "Delete" button has focus and the tab key is pressed > should redirect focus to the "Next Focusable Button" button Screenshots Video

Review all test suite changes for PR #2485 ↗︎

@josh-bagwell josh-bagwell self-assigned this Jan 2, 2024
@josh-bagwell josh-bagwell linked an issue Jan 2, 2024 that may be closed by this pull request
@josh-bagwell josh-bagwell added the ready for review Code is ready for review label Jan 5, 2024
@josh-bagwell josh-bagwell marked this pull request as ready for review January 5, 2024 18:51
@mannycarrera4 mannycarrera4 added approved Code has been reviewed and approved (ship it) and removed ready for review Code is ready for review labels Jan 17, 2024
@alanbsmith alanbsmith enabled auto-merge (squash) January 17, 2024 18:14
@alanbsmith alanbsmith merged commit 524bc66 into Workday:prerelease/major Jan 17, 2024
17 checks passed
@alanbsmith alanbsmith mentioned this pull request Feb 14, 2024
10 tasks
@alanbsmith alanbsmith mentioned this pull request May 14, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11.x approved Code has been reviewed and approved (ship it) automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply Updates to Components discovered in Audit
4 participants