Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix CountBadge display name #2740

Merged

Conversation

alanbsmith
Copy link
Member

@alanbsmith alanbsmith commented May 14, 2024

Summary

Fixes CountBadge display name

Release Category

Components


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@alanbsmith alanbsmith changed the base branch from master to prerelease/major May 14, 2024 15:57
@alanbsmith alanbsmith added the ready for review Code is ready for review label May 14, 2024
@@ -68,7 +68,7 @@ const countBadgeStencil = createStencil({
* `CountBadge` provides a quantity-based summary with dynamic values.
*/
export const CountBadge = createComponent('span')({
displayName: 'NewCountBadge',
displayName: 'CountBadge',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏼

Copy link

cypress bot commented May 14, 2024

Passing run #7293 ↗︎

0 970 3 0 Flakiness 0

Details:

Merge 64c340b into 4aa8870...
Project: canvas-kit Commit: 8c0cd76156 ℹ️
Status: Passed Duration: 05:12 💡
Started: May 14, 2024 4:02 PM Ended: May 14, 2024 4:07 PM

Review all test suite changes for PR #2740 ↗︎

@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels May 14, 2024
@alanbsmith alanbsmith merged commit a0579b1 into Workday:prerelease/major May 14, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants