chore: Refactor Checkbox styles #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #6865 ↗︎
Details:
Review all test suite changes for PR #2542 ↗︎ |
||||||||||||||||||||
mannycarrera4
changed the title
alanbsmith
changed the title
alanbsmith
reviewed
Feb 2, 2024
alanbsmith
requested changes
Feb 2, 2024
There was a problem hiding this comment.
Nice work, @RayRedGoose! I made some comments and suggestions.
- Let's go ahead and convert all
pxvalues torem - Be sure to check styles like
marginLeftto make sure they still work with RTL
Otherwise, this looks great. 😄
|
|
||
| const checkboxRippleStyles = createStyles({ | ||
| borderRadius: system.shape.round, | ||
| boxShadow: `0 0 0 0 ${base.soap200}`, |
There was a problem hiding this comment.
Question: A 0 0 0 0 box shadow shouldn't render anything. I see there's a transition for it, but I don't know how it's transitioning?
There was a problem hiding this comment.
Okay, I changed it to 'none' and it made some changes to inverse variant:
old
new
As you can see old version has small round inside box
There was a problem hiding this comment.
I don't think this round should be visible at all
There was a problem hiding this comment.
If you agree to remove it, please, approve visual changes in chromatic
RayRedGoose
force-pushed
the
ISSUE2395_checkbox-style-refactoring
branch
from
3a59f40
to
dfc4ca8
Compare
Co-authored-by: Manuel Carrera <mannycarrera4@users.noreply.github.com>
Co-authored-by: Manuel Carrera <mannycarrera4@users.noreply.github.com>
Co-authored-by: Manuel Carrera <mannycarrera4@users.noreply.github.com>
Co-authored-by: Manuel Carrera <mannycarrera4@users.noreply.github.com>
Co-authored-by: Alan B Smith <a.bax.smith@gmail.com>
alanbsmith
approved these changes
Feb 8, 2024
alanbsmith
added
approved
10 tasks
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2395
Refactors styles in
Checkboxusing new style utilities.Release Category
Components
Release Note
Checkboxnow uses Canvas Tokens and our new styling utilities. The component now supports thecsprop, but otherwise the API has not changed. It should behave identically as it did in previous versions.