-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Radio Styles Refactor #2546
Merged
alanbsmith
merged 12 commits into
Workday:prerelease/major
from
josh-bagwell:radio-refactor-24-01
Feb 5, 2024
Merged
chore: Radio Styles Refactor #2546
alanbsmith
merged 12 commits into
Workday:prerelease/major
from
josh-bagwell:radio-refactor-24-01
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #6805 ↗︎
Details:
Review all test suite changes for PR #2546 ↗︎ |
UI Tests show the update to the |
Closed
alanbsmith
requested changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. Thanks for working on this, @josh-bagwell! A few main notes:
- If the component is already supporting style props, use
mergeStyles
instead ofhandleCSProp
for backwards compatibility. - Let's go ahead and move everything to rem while we're refactoring
- Use the
calc
functions – I made them for you. 😄 - Maybe consolidate common styles
alanbsmith
reviewed
Feb 2, 2024
alanbsmith
approved these changes
Feb 5, 2024
10 tasks
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors styles in
Radio
andRadioGroup
using new style utilities.Fixes: #2396
Release Category
Components
Release Note
Radio
andRadioGroup
now use Canvas Tokens and our new styling utilities. The component now supports thecs
prop, but otherwise the API has not changed. It should behave identically as it did in previous versions however, there may be some slight visual changes.BREAKING CHANGES
There may be slight visual changes.
For the Reviewer
Where Should the Reviewer Start?
/modules/preview-react/radio/lib/RadioGroup.tsx
/modules/preview-react/radio/lib/Radio.tsx