Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(button): Refactor button to use system tokens #2666

Merged
merged 53 commits into from
Apr 17, 2024
Merged

chore(button): Refactor button to use system tokens #2666

merged 53 commits into from
Apr 17, 2024

Conversation

josh-bagwell
Copy link
Contributor

@josh-bagwell josh-bagwell commented Mar 25, 2024 •
edited
Loading

Summary

Fixes: #2402

  • Refactor Button styles to use system tokens and remove base tokens.
  • Refactor Button styles to utilize stencils

Release Category

Components

Release Note

Updated Buttons to use new system tokens.

BREAKING CHANGES

Visual Breaking Change

  • There may be a small visual change to SecondaryButton when the border for the focus state was updated from soap400 to transparent.

Checklist

Where Should the Reviewer Start?

/modules/react/button

art

@josh-bagwell
Copy link
Contributor Author

josh-bagwell commented Mar 25, 2024 •
edited
Loading

There may be a couple system tokens usage that doesn't make sense 1:1 since a color may have been missing.

@josh-bagwell josh-bagwell self-assigned this Mar 25, 2024
@josh-bagwell josh-bagwell marked this pull request as ready for review March 25, 2024 21:13
@josh-bagwell josh-bagwell added the ready for review Code is ready for review label Mar 25, 2024
@josh-bagwell josh-bagwell linked an issue Mar 25, 2024 that may be closed by this pull request
Button Style Refactors - Color Tokens #2402
Closed
@cypress Cypress
Copy link

cypress bot commented Mar 25, 2024 •
edited
Loading

Passing run #7210 ↗︎

0 970 3 0 Flakiness 0

Details:

Merge 979cb7b into 6ccdc31...
Project: canvas-kit Commit: 336b7e1549 ℹ️
Status: Passed Duration: 05:07 💡
Started: Apr 17, 2024 9:19 PM Ended: Apr 17, 2024 9:24 PM

Review all test suite changes for PR #2666 ↗︎

@josh-bagwell josh-bagwell removed the ready for review Code is ready for review label Mar 25, 2024
@josh-bagwell josh-bagwell added the ready for review Code is ready for review label Mar 27, 2024
@NicholasBoll NicholasBoll added the review in progress Code is currently under review label Apr 12, 2024
@NicholasBoll NicholasBoll changed the title chore: Button System Tokens Refactor chore(button): Refactor button to use system tokens Apr 12, 2024
@josh-bagwell josh-bagwell added automerge and removed ready for review Code is ready for review review in progress Code is currently under review labels Apr 17, 2024
@alanbsmith alanbsmith merged commit 54f26ac into Workday:prerelease/major Apr 17, 2024
19 checks passed
@alanbsmith alanbsmith mentioned this pull request Apr 24, 2024
Merged
10 tasks
@alanbsmith alanbsmith mentioned this pull request May 14, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasBoll NicholasBoll NicholasBoll left review comments

@mannycarrera4 mannycarrera4 mannycarrera4 approved these changes

@RayRedGoose RayRedGoose RayRedGoose left review comments

@alanbsmith alanbsmith Awaiting requested review from alanbsmith

Assignees

@josh-bagwell josh-bagwell

Labels
11.x automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button Style Refactors - Color Tokens
5 participants
@josh-bagwell @NicholasBoll @mannycarrera4 @RayRedGoose @alanbsmith