docs: Improve the "accessible" example of loading dots #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is not fully resolving issue #2668. This component hasn't been modified to support consumers passing in their own colors to the |
Passing run #7196 ↗︎
Details:
Review all test suite changes for PR #2673 ↗︎ |
|||||||||||||||
jaclynjessup
added
ready for review
RayRedGoose
reviewed
Apr 8, 2024
RayRedGoose
reviewed
Apr 11, 2024
RayRedGoose
reviewed
Apr 11, 2024
RayRedGoose
previously approved these changes
Apr 11, 2024
Co-authored-by: Raisa Primerova <48605821+RayRedGoose@users.noreply.github.com>
NicholasBoll
changed the title
RayRedGoose
dismissed
their stale review
Missed createStyles in render function
Co-authored-by: Nicholas Boll <nicholas.boll@gmail.com>
RayRedGoose
approved these changes
Apr 15, 2024
NicholasBoll
approved these changes
Apr 15, 2024
NicholasBoll
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Soap400 color for the
LoadingDotscomponent does not meet WCAG guidelines for non-text contrast while used on light background colors. For this example, I used a darker background color that allows Soap400 to meet the minimum 3:1 contrast ratio. I also added better screen reader support with theAriaLiveRegioncomponent that both lets users know about the loading status, and when loading has completed.Release Category
Documentation
Release Note
Accessible
LoadingDotsexample has been updated, by changing background to a darker color that allowssoap400to meet the minimum 3:1 contrast ratio and adding better screen reader support with theAriaLiveRegioncomponent.Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
The "Accessible" example of the
LoadingDotscomponent, and the storybook mdx file.Areas for Feedback? (optional)
Testing Manually
NOTE: The term "loading" is coming from an
aria-labelstring on thestatusregion. The order in which "loading" is described might vary based on screen reader.Screenshots or GIFs (if applicable)
I used licorice300 for a background color of the
LoadingDotsaccessible example.