chore: Refactor StatusIndicator to use system colors #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayRedGoose
commented
Apr 18, 2024
1 flaky test on run #7232 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > when the "Delete" button has focus and the tab key is pressed > should hide the popup |
Screenshots
Video
|
|
Review all test suite changes for PR #2700 ↗︎
Co-authored-by: Manuel Carrera <mannycarrera4@users.noreply.github.com>
Co-authored-by: Manuel Carrera <mannycarrera4@users.noreply.github.com>
mannycarrera4
approved these changes
Apr 19, 2024
mannycarrera4
added
approved
josh-bagwell
approved these changes
Apr 19, 2024
Co-authored-by: Josh <44883293+josh-bagwell@users.noreply.github.com>
RayRedGoose
added
automerge
and removed
approved
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2596
StatusIndicatorhas been updated to use system colors and its model has been removed.Release Category
Components
Release Note
As part of the refactor, we've removed the following exports that were primarily used to style the component:
useStatusIndicatorModeluseStatusIndicatorstatusIndicatorColorsuseStatusIndicatorIcon.Since there was no usage of these by our consumers, there should be no breaking changes.
BREAKING CHANGES
There's a visual breaking change. The
transparentvariant now usessystem.color.bg.translucent.