Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(text-input): Change tests to react-testing-library and improve coverage #390

Merged
merged 17 commits into from
Jan 24, 2020
Merged

test(text-input): Change tests to react-testing-library and improve coverage #390

merged 17 commits into from
Jan 24, 2020

Conversation

stephanerangaya
Copy link
Contributor

@stephanerangaya stephanerangaya commented Jan 2, 2020

Summary

Related to #286

Converts test to RTL, improves coverage, adds a static states story for visual regression testing, and uses a more BDD (behavioral-driven) approach for unit tests.

Checklist

  • branch has been rebased on the latest master commit
  • tests are changed or added
  • yarn test passes
  • all (dev)dependencies that the module needs is added to its package.json
  • code adheres to the API & Pattern guidelines

@lychyi lychyi mentioned this pull request Jan 2, 2020
31 tasks
@cypress
Copy link

cypress bot commented Jan 2, 2020



Test summary

76 0 0 0


Run details

Project canvas-kit
Status Passed
Commit 4c668d8
Started Jan 24, 2020 10:00 PM
Ended Jan 24, 2020 10:01 PM
Duration 01:31 💡
OS Linux Ubuntu Linux - 16.04
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lychyi lychyi added this to In progress in Current Sprint (7/20 - 8/9) via automation Jan 3, 2020
@stephanerangaya stephanerangaya changed the title test(text-input): Switch tests to RTL test(text-input): Change tests to react-testing-library and improve coverage Jan 13, 2020
@anicholls anicholls merged commit 23e8d15 into Workday:master Jan 24, 2020
Current Sprint (7/20 - 8/9) automation moved this from In progress (PRs) to Done Jan 24, 2020
@jpante jpante added this to the Component Testing Coverage milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants