Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❗Component Testing Checklist #286

Closed
23 of 31 tasks
lychyi opened this issue Oct 29, 2019 · 2 comments
Closed
23 of 31 tasks

❗Component Testing Checklist #286

lychyi opened this issue Oct 29, 2019 · 2 comments
Projects
Backlog

Comments

@lychyi
Copy link
Contributor

lychyi commented Oct 29, 2019 •
edited by NicholasBoll
Loading

Test Coverage Checklist

Reference to PR that removed snapshots (#259) for reference when re-writing tests that we blew away from this.

Blockers

  • Storybook does not load into IE11
  • Storybook 5.2 gets merged (build: Upgrade Storybook to 5.2 #267) for MDX - Format for visual tests will be reconsidered after Storybook 5.2 gets merged

Guides

Testing philosophy and guidelines

React

For these components, we'll have to ensure we have adequate coverage for unit tests (Jest, React Testing Library) and specification/e2e tests (Cypress).

Canvas Kit React

Canvas Kit Labs React

Canvas Kit Preview React

Canvas Kit Labs React (WIP)

CSS

For these components, visual regression (Storybook and Chromatic) and sometimes specification/e2e tests (Cypress).
@lychyi lychyi pinned this issue Oct 29, 2019
@lychyi lychyi changed the title Component Testing Checklist ❗Component Testing Checklist Dec 4, 2019
@lychyi lychyi moved this from Backlog to To Do (This Sprint) in Current Sprint (7/20 - 8/9) Dec 9, 2019
@stephanerangaya stephanerangaya mentioned this issue Dec 13, 2019
Closed
@anicholls anicholls mentioned this issue Dec 13, 2019
Merged
5 tasks
@mannycarrera4 mannycarrera4 mentioned this issue Dec 18, 2019
Merged
9 tasks
@lychyi lychyi moved this from To Do (This Sprint) to To Do (Next Sprint) in Current Sprint (7/20 - 8/9) Jan 6, 2020
@lychyi lychyi moved this from Work (Next Sprint) to Work (This Sprint) in Current Sprint (7/20 - 8/9) Jan 7, 2020
@sahlhoff sahlhoff mentioned this issue Jan 17, 2020
Merged
@jamesfan jamesfan mentioned this issue Jan 23, 2020
Merged
5 tasks
This was referenced Jan 24, 2020
Merged
Merged
@lychyi lychyi moved this from Work (This Sprint) to Work (Next Sprint) in Current Sprint (7/20 - 8/9) Feb 3, 2020
@lychyi lychyi moved this from Work (Next Sprint) to Backlog in Current Sprint (7/20 - 8/9) Feb 4, 2020
@lychyi lychyi moved this from Backlog to Work (This Sprint) in Current Sprint (7/20 - 8/9) Feb 18, 2020
@mannycarrera4 mannycarrera4 mentioned this issue Mar 4, 2020
Merged
3 tasks
NicholasBoll added a commit to NicholasBoll/canvas-kit that referenced this issue Mar 20, 2020
@NicholasBoll
test(tooltip): Add tooltip specifications
bf24320 
* Add unit tests
* Add Cypress specifications
* Add visual tests
* Upgrade Popper to v2 and use canvas-kit Popper component instead of materia-ui's

Tooltip portion of Workday#286
NicholasBoll added a commit to NicholasBoll/canvas-kit that referenced this issue Mar 20, 2020
@NicholasBoll
test(tooltip): Add tooltip specifications
f6a16ca 
* Add unit tests
* Add Cypress specifications
* Add visual tests
* Upgrade Popper to v2 and use canvas-kit Popper component instead of materia-ui's

Tooltip portion of Workday#286
NicholasBoll added a commit to NicholasBoll/canvas-kit that referenced this issue Mar 20, 2020
@NicholasBoll
test(tooltip): Add tooltip specifications
83385ff 
* Add unit tests
* Add Cypress specifications
* Add visual tests
* Upgrade Popper to v2 and use canvas-kit Popper component instead of materia-ui's

Tooltip portion of Workday#286
@NicholasBoll NicholasBoll mentioned this issue Mar 20, 2020
Merged
7 tasks
@jpante
Copy link
Member

jpante commented Apr 3, 2020

Converting this to a Milestone.

@jpante jpante added this to Open in Backlog via automation May 12, 2020
@jpante jpante removed this from To-do (This Sprint) in Current Sprint (7/20 - 8/9) May 12, 2020
@jpante jpante unpinned this issue Jul 27, 2020
@jpante jpante moved this from Open to Notes/Questions in Backlog Jan 4, 2021
@jaclynjessup jaclynjessup mentioned this issue Sep 8, 2022
Open
@jaclynjessup
Copy link
Member

Closing in favor of #1773 to investigate current testing gaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Canvas Kit
Status: ✅ Done
Backlog
  
Notes/Questions
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpante @lychyi @jaclynjessup