Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(select): Change tests to react-testing-library and improve coverage #412

Merged
merged 9 commits into from
Feb 7, 2020

Conversation

jamesfan
Copy link
Member

@jamesfan jamesfan commented Jan 16, 2020

Summary

Related to #286

Converts test to RTL, improves coverage, adds a static states story for visual regression testing, and uses a more BDD (behavioral-driven) approach for unit tests.

Checklist

  • branch has been rebased on the latest master commit
  • tests are changed or added
  • yarn test passes
  • all (dev)dependencies that the module needs is added to its package.json
  • code adheres to the API & Pattern guidelines

@jamesfan jamesfan added this to In progress (PRs) in Current Sprint (7/20 - 8/9) via automation Jan 16, 2020
@cypress
Copy link

cypress bot commented Jan 16, 2020



Test summary

155 0 0 0


Run details

Project canvas-kit
Status Passed
Commit ff4f316
Started Feb 7, 2020 12:39 AM
Ended Feb 7, 2020 12:43 AM
Duration 03:29 💡
OS Linux Ubuntu Linux - 16.04
Browser Electron 78

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jamesfan jamesfan marked this pull request as ready for review January 17, 2020 02:01
@anicholls anicholls force-pushed the testing-select branch 2 times, most recently from 8415efb to 2142386 Compare January 27, 2020 21:04
@lychyi lychyi mentioned this pull request Feb 3, 2020
31 tasks
@anicholls anicholls merged commit 48879d9 into Workday:master Feb 7, 2020
Current Sprint (7/20 - 8/9) automation moved this from In progress (PRs) to Done Feb 7, 2020
@jpante jpante added this to the Component Testing Coverage milestone Apr 3, 2020
@jamesfan jamesfan deleted the testing-select branch May 5, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants