test: Explicitly enable snapshots #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
mannycarrera4
approved these changes
Feb 21, 2020
| @@ -171,7 +171,12 @@ const CheckboxStates = () => ( | |||
| ); | |||
|
|
|||
| storiesOf('Components|Inputs/Checkbox/React/Visual Testing', module) | |||
| .addParameters({component: Checkbox}) | |||
| .addParameters({ | |||
| component: Checkbox, | |||
There was a problem hiding this comment.
Interesting. It seems like Storybook is able to get the component just fine without this, but I'm not sure why.
NicholasBoll
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
I think we'll need to add a note in our documentation about this. We've been saying every story is automatically a visual regression - now we have to say it is not. Our documentation will have to say that visual stories are now intentional and we have to opt into capturing.
Merged
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are testing way too many stories that aren't useful for visual regression. This PR tells Chromatic to ignore all stories by default and only include ones that are marked.
Checklist
yarn testpassespackage.jsoncanvas-kit-reactand/orcanvas-kit-cssuniversal modules, ifapplicable
Additional References