Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Explicitly enable snapshots #478

Merged
merged 3 commits into from
Feb 21, 2020
Merged

test: Explicitly enable snapshots #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c73b50
chore: Upgrade chromatic to latest
lychyi Feb 21, 2020
cf2437e
test: Ignore all stories for Chromatic
lychyi Feb 21, 2020
7965ab7
test: Progressively add stories to Chromatic
lychyi Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .storybook/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ addParameters({
readme: {
codeTheme: 'github',
},
chromatic: {
disable: true
}
});

configure(loadStories, module);
7 changes: 6 additions & 1 deletion modules/form-field/react/stories/stories_Checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,12 @@ const CheckboxStates = () => (
);

storiesOf('Components|Inputs/Checkbox/React/Visual Testing', module)
.addParameters({component: Checkbox})
.addParameters({
component: Checkbox,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. It seems like Storybook is able to get the component just fine without this, but I'm not sure why.

chromatic: {
disable: false,
},
})
.addDecorator(withReadme(README))
.add('States', () => <CheckboxStates />)
.addParameters({
Expand Down
7 changes: 6 additions & 1 deletion modules/form-field/react/stories/stories_ColorInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,12 @@ const ColorInputStates = () => (
);

storiesOf('Components|Inputs/Color Picker/Color Input/React/Visual Testing', module)
.addParameters({component: ColorInput})
.addParameters({
component: ColorInput,
chromatic: {
disable: false,
},
})
.addDecorator(withReadme(README))
.add('States', () => <ColorInputStates />)
.addParameters({
Expand Down
7 changes: 6 additions & 1 deletion modules/form-field/react/stories/stories_Radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,12 @@ const RadioStates = () => (
);

storiesOf('Components|Inputs/Radio/React/Visual Testing', module)
.addParameters({component: Radio})
.addParameters({
component: Radio,
chromatic: {
disable: false,
},
})
.addDecorator(withReadme(README))
.add('States', () => <RadioStates />)
.addParameters({
Expand Down
7 changes: 6 additions & 1 deletion modules/form-field/react/stories/stories_Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,12 @@ storiesOf('Components|Inputs/Select/React/Left Label', module)
));

storiesOf('Components|Inputs/Select/React/Visual Testing', module)
.addParameters({component: Select})
.addParameters({
component: Select,
chromatic: {
disable: false,
},
})
.addDecorator(withReadme(README))
.add('States', () => (
<StaticStates>
Expand Down
7 changes: 6 additions & 1 deletion modules/form-field/react/stories/stories_Switch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,12 @@ const SwitchStates = () => (
);

storiesOf('Components|Inputs/Switch/React/Visual Testing', module)
.addParameters({component: Switch})
.addParameters({
component: Switch,
chromatic: {
disable: false,
},
})
.addDecorator(withReadme(README))
.add('States', () => <SwitchStates />)
.addParameters({
Expand Down
7 changes: 6 additions & 1 deletion modules/form-field/react/stories/stories_TextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,12 @@ const TextAreaStates = () => (
);

storiesOf('Components|Inputs/TextArea/React/Visual Testing', module)
.addParameters({component: TextArea})
.addParameters({
component: TextArea,
chromatic: {
disable: false,
},
})
.addDecorator(withReadme(README))
.add('States', () => <TextAreaStates />)
.addParameters({
Expand Down
7 changes: 6 additions & 1 deletion modules/form-field/react/stories/stories_TextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,12 @@ const TextInputStates = () => (
);

storiesOf('Components|Inputs/Text Input/React/Visual Testing', module)
.addParameters({component: TextInput})
.addParameters({
component: TextInput,
chromatic: {
disable: false,
},
})
.addDecorator(withReadme(README))
.add('States', () => <TextInputStates />)
.addParameters({
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"rollup-plugin-node-resolve": "^5.1.0",
"rollup-plugin-terser": "^5.0.0",
"sass-loader": "^8.0.0",
"storybook-chromatic": "^3.4.1",
"storybook-chromatic": "^3.5.2",
"storybook-readme": "^5.0.8",
"style-loader": "^1.0.0",
"ts-loader": "^6.2.0",
Expand Down
Loading