feat(combobox): Allow grouping of listbox items #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
anicholls
added
the
blocked
|
Reviewed Matt's work with NVDA/JAWS. Sounds good to me. |
vibdev
changed the title
vibdev
commented
May 5, 2020
| ); | ||
| }; | ||
|
|
||
| export default Status; |
There was a problem hiding this comment.
Broke this out, might be nice for it to be its own component at some point.
anicholls
added
ready for review
vibdev
commented
Jun 4, 2020
NicholasBoll
reviewed
Jun 9, 2020
NicholasBoll
reviewed
Jun 9, 2020
Comment on lines
25
to
30
| // TODO: useContext should not be called conditionally, | ||
| // but to keep this function working we need to ignore till a refactor can happen. | ||
| // Ideally there is a getTheme and a useTheme separately where getTheme is used outside of functional components | ||
| // and useTheme is used inside functional components. Then this try won’t be necessary. | ||
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const context = React.useContext(ThemeContext); |
# Conflicts: # modules/_labs/combobox/react/lib/Combobox.tsx # modules/_labs/combobox/react/stories/stories.tsx # modules/_labs/core/react/lib/theming/useTheme.ts
* Fixed some various bugs while writing tests * Removed Jest tests that are now covered by Cypress
|
Paired with @vibdev to add Cypress tests, fix various bugs found while writing tests and removed Jest tests that are now covered with Cypress |
NicholasBoll
reviewed
Jul 7, 2020
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "projectId": "odida5", | |||
| "baseUrl": "http://localhost:9001", | |||
| "supportFile": "cypress/support/index.ts" | |||
| "supportFile": "cypress/support/index.ts", | |||
| "watchForFileChanges": false | |||
There was a problem hiding this comment.
I added this. I think it's annoying to write a bit of test code, then go back to Cypress to find out what I'm querying the DOM for and the Cypress test starts over again increasing time to write tests rather than decreasing it.
NicholasBoll
approved these changes
Jul 7, 2020
…ete-wip # Conflicts: # modules/_labs/combobox/react/lib/Combobox.tsx # modules/_labs/combobox/react/stories/stories.tsx
NicholasBoll
added
approved
Merged
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds groups for combobox. This is WIP so accessibility team can audit.
Checklist
yarn testpassespackage.jsoncanvas-kit-reactand/orcanvas-kit-cssuniversal modules, ifapplicable
Additional References