test(toast): Write test for Toasts #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannycarrera4
commented
Apr 16, 2020
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
mannycarrera4
commented
Apr 20, 2020
mannycarrera4
commented
Apr 20, 2020
alanbsmith
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Solid work, @mannycarrera4! I had a few comments and questions, but nothing that would hold this up. The only thing I might change is adding a data-testid on the button instead of using an aria-label for the reasons you mentioned.
anicholls
reviewed
Apr 21, 2020
Closed
anicholls
approved these changes
Apr 22, 2020
Co-Authored-By: Alex Nicholls <anicholls3@gmail.com>
This was referenced May 5, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We hadn't written test for Toast yet. While writing some test, I noticed that adding some accessibility to the toast helped with the test. There's still some accessibility to add to the toast.