Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 New Component: SidePanel (Labs) #866

Merged
merged 59 commits into from
Nov 6, 2020
Merged
Show file tree
Hide file tree
Changes from 57 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
c173fd6
feat(side-panel): Init Labs Side Panel
lychyi Aug 21, 2020
1ab9273
feat(side-panel): Add todo item
lychyi Aug 24, 2020
7a0125a
Merge branch 'master' of https://github.com/Workday/canvas-kit into s…
lychyi Aug 31, 2020
a42345b
Merge branch 'master' of https://github.com/Workday/canvas-kit into s…
lychyi Sep 12, 2020
a9e88a5
feat(side-panel): Init Side Panel
lychyi Sep 18, 2020
6ae4407
Merge branch 'master' of https://github.com/Workday/canvas-kit into s…
lychyi Sep 26, 2020
ae32fbd
chore(side-panel): Add notes
lychyi Sep 26, 2020
6a19f27
feat(side-panel): Return isControlled boolean
lychyi Sep 26, 2020
9690f43
fix(side-panel): Change default height
lychyi Sep 26, 2020
b133b32
test(side-panel): Clean up visual tests
lychyi Sep 26, 2020
2b1c98a
perf(common): Optimize useUniqueId hook
lychyi Sep 26, 2020
cf84d3d
chore(side-panel): Add some notes
lychyi Sep 26, 2020
3f4222b
fix(side-panel): Make event handlers more specific
lychyi Sep 26, 2020
d5ca0f0
docs(side-panel): Correct jsdoc default values
lychyi Sep 26, 2020
9d3881a
feat(side-panel): Separate state callbacks
lychyi Sep 26, 2020
ac4863f
test(side-panel): Init cypress tests
lychyi Sep 28, 2020
13b746e
chore(side-panel): Add a note for potential bug
lychyi Sep 28, 2020
0ad05da
chore(side-panel): Add missing deps
lychyi Sep 28, 2020
67efbeb
chore: Revert inadvertant yarn.lock changes
lychyi Sep 29, 2020
fc2d4b7
revert: Rollback useUniqueId changes
lychyi Sep 30, 2020
5ad218a
feat(side-panel): Add aria-label attr
lychyi Oct 2, 2020
dafa7cc
feat(side-panel): Refactor using hooks
lychyi Oct 8, 2020
988348d
fix(side-panel): Add type=button
lychyi Oct 8, 2020
7f6052e
chore(side-panel): Add deps for stories
lychyi Oct 8, 2020
9a35375
Merge branch 'master' into sidepanel
lychyi Oct 9, 2020
9525c73
feat(side-panel): Add 'as' prop to specify the rendered element
lychyi Oct 13, 2020
e6c76d7
docs(side-panel): Sync up docs
lychyi Oct 13, 2020
ee30da8
fix(side-panel): Remove hidden label static
lychyi Oct 13, 2020
86543f3
docs: Remove magic section styling in storybook
lychyi Oct 13, 2020
0f9fb80
Merge branch 'master' into sidepanel
lychyi Oct 13, 2020
33b6a8a
chore(side-panel): Update deps
lychyi Oct 13, 2020
93a4d6c
docs(side-panel): Clean up stories
lychyi Oct 13, 2020
0ddb7a1
chore: Add common module back into package.json
lychyi Oct 13, 2020
ee501ed
fix(side-panel): Hide header properly in story
lychyi Oct 16, 2020
1184430
Merge branch 'master' into sidepanel
lychyi Oct 17, 2020
767d8ba
fix(side-panel): Require aria-label or labelled-by
lychyi Oct 17, 2020
fe62e14
chore: Update Cypress
lychyi Oct 30, 2020
011b172
test(side-panel): Add Cypress tests
lychyi Oct 30, 2020
8a50a60
fix(side-panel): Address PR comments
lychyi Oct 30, 2020
ab71869
docs(side-panel): Fix default hook example
lychyi Oct 30, 2020
03eda56
chore(side-panel): Add better typings to hooks
lychyi Oct 30, 2020
42347dd
test(side-panel): Add unit tests for hook
lychyi Oct 30, 2020
08eeea1
fix(side-panel): Replace emotion styled with ours
lychyi Oct 30, 2020
434f04e
fix(side-panel): Make code more readable
lychyi Oct 30, 2020
6870461
chore(side-panel): Use Record type
lychyi Oct 30, 2020
e6c190d
test(side-panel): Fix visual tests
lychyi Oct 30, 2020
3365528
docs(side-panel): Fix readme for hooks
lychyi Oct 30, 2020
2482039
chore: Add @testing-library/react-hooks dep to ignore list
lychyi Oct 30, 2020
8faa5c4
chore(side-panel): Remove unused dep
lychyi Oct 30, 2020
9caf331
Merge branch 'master' into sidepanel
lychyi Oct 30, 2020
d95ed68
Merge branch 'sidepanel' of https://github.com/lychyi/canvas-kit into…
lychyi Oct 30, 2020
a949f42
fix(side-panel): Remove height prop, minWidth spec
lychyi Oct 30, 2020
b2394ac
fix(side-panel): Switch to Plain IconButton variant
lychyi Nov 2, 2020
689e85a
fix(side-panel): Override Plain toggle's margin
lychyi Nov 3, 2020
69a30c8
Merge branch 'master' into sidepanel
lychyi Nov 3, 2020
6c21859
test(side-panel): Add aria-controls test
lychyi Nov 3, 2020
118c97a
Merge branch 'sidepanel' of https://github.com/lychyi/canvas-kit into…
lychyi Nov 3, 2020
748a80b
test(side-panel): Remove branching logic
lychyi Nov 4, 2020
5859ac4
test(side-panel): Add first focusable test
lychyi Nov 5, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions cypress/integration/SidePanelLabs.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
import * as h from '../helpers';

describe('Side Panel', () => {
before(() => {
h.stories.visit();
});

['Default', 'AsAside', 'AsDiv'].forEach(story => {
context(`given the "${story}" story is rendered`, () => {
beforeEach(() => {
h.stories.load('Testing|React/Labs/Side Panel/Cypress', story);
});

const name = /Accessible Label Name/i;

it('should not have any axe errors', () => {
cy.checkA11y();
});

context('the button', () => {
it(`should have an accessible name`, () => {
cy.findByRole('button', {name}).should('exist');
});

it(`should have an aria-expanded attribute of 'true'`, () => {
cy.findByRole('button', {name}).should('have.attr', 'aria-expanded', 'true');
});

it(`should have an aria-controls attribute equal to the id of the panel`, () => {
cy.findByRole('button', {name}).then(button => {
const buttonAriaControlsValue = button.attr('aria-controls');
switch (story) {
case 'AsAside':
cy.findByRole('complementary', {name}).should(
'have.attr',
'id',
buttonAriaControlsValue
);
break;
default:
cy.findByRole('region', {name}).should('have.attr', 'id', buttonAriaControlsValue);
}
});
});
});
lychyi marked this conversation as resolved.
Show resolved Hide resolved

it(`should have a panel with a landmark role`, () => {
switch (story) {
case 'AsAside':
cy.findByRole('complementary', {name}).should('exist');
break;
default:
cy.findByRole('region', {name}).should('exist');
}
});

context('when tabbing', () => {
lychyi marked this conversation as resolved.
Show resolved Hide resolved
beforeEach(() => {
cy.tab();
});

context('the button', () => {
it('should be focused', () => {
cy.findByRole('button', {name}).should('have.focus');
});
});
});
lychyi marked this conversation as resolved.
Show resolved Hide resolved

context(`when collapsing the panel`, () => {
beforeEach(() => {
cy.findByRole('button', {name}).click();
});

context('the button', () => {
it(`should have an aria-expanded attribute of 'false'`, () => {
cy.findByRole('button', {name}).should('have.attr', 'aria-expanded', 'false');
});
});
});
});
});
});
52 changes: 52 additions & 0 deletions modules/_labs/side-panel/react/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
Apache License, Version 2.0 Apache License Version 2.0, January 2004

http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.
"License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document.
"Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License.
"Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity.
"You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License.
"Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files.
"Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types.
"Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below).
"Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof.
"Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution."
"Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work.

2. Grant of Copyright License.
Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form.

3. Grant of Patent License.
Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed.

4. Redistribution.
You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions:
You must give any other recipients of the Work or Derivative Works a copy of this License; and You must cause any modified files to carry prominent notices stating that You changed the files; and You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License.

5. Submission of Contributions.
Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions.

6. Trademarks.
This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty.
Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License.

8. Limitation of Liability.
In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability.
While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

©2020. Workday, Inc. All rights reserved. Workday and the Workday logo are registered trademarks of Workday, Inc. All other brand and product names are trademarks or registered trademarks of their respective holders.


Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
128 changes: 128 additions & 0 deletions modules/_labs/side-panel/react/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
# Canvas Kit React Side Panel

<a href="https://github.com/Workday/canvas-kit/tree/master/modules/_labs/README.md">
<img src="https://img.shields.io/badge/LABS-alpha-orange" alt="LABS: Alpha" />
</a> This component is work in progress and currently in pre-release.

A collapsable side panel

## Installation

```sh
yarn add @workday/canvas-kit-labs-react-side-panel
```

## Usage

```tsx
import SidePanel, {useSidePanel} from '@workday/canvas-kit-labs-react-side-panel';

/**
* A SidePanel is made up of three components
* - The panel itself <SidePanel>
* - An accessible name (either an existing element or you can use <span hidden>)
* - A control that expands/collapses the SidePanel, usually <SidePanel.ToggleButton> as a child of <SidePanel>
* A convenience hook is available for setting the state of the SidePanel along with the proper aria- attributes
*
*/
const {panelProps, labelProps, controlProps} = useSidePanel();

<SidePanel {...panelProps}>
<SidePanel.ToggleButton {...controlProps} />
<h3 {...labelProps}>Tasks Panel</h3>
{/* Your panel contents */}
</SidePanel>

```
## Hooks
### `useSidePanel`
This hook manages the state and `aria-` attributes for the SidePanel. It takes in a `config` object:
* `intialExpanded: boolean`: Specifies the initial expanded/collapsed state of the side panel.
* `panelId: string`: specifies the id of the panel, if `undefined` then this hook will generate one
* `labelId: string` specifies the id of the label, if `undefined` then this hook will generate one

and returns:
* `expanded: boolean`: The state for the `SidePanel`'s `expanded` prop.
* `setExpanded: (expanded?: boolean) => void`: A function that sets the `expanded` state.
* `panelProps: object`: Contains the `expanded`, `id`, and `aria-labelledby` props for the `SidePanel` (or equivalent) component.
* `labelProps: object`: Contains the `id` prop for the label.
* `controlProps: object`: Contains the `aria-controls`, `aria-expanded`, `aria-labelledby`, and click handler for the side panel's control element.

#### Usage
```tsx
const [expanded, setExpanded, panelProps, labelProps, controlProps] = useSidePanel({
initialExpanded: true,
panelId: 'side-panel-1',
labelId: 'side-panel-label-1'
});

<SidePanel {...panelProps}>
{/* Make sure the control is first focusable */}
<SidePanel.ToggleButton {...controlProps} />
<span hidden {...labelProps}>Example Panel</span>
{/* Rest of the children here */}
</SidePanel>

or

<SidePanel {...panelProps}>
{/* If you want to use your own button */}
<CustomControl {...controlProps} />
{/* If you already have an element that can be an accessible name for the panel */}
<h3 {...labelProps}>Example Panel</h3>
</SidePanel>
```

## Static Properties

#### `ToggleButton`
> `<SidePanel.ToggleButton>` is a control that is meant to toggle between `expanded = true` and `expanded = false` states. It must be used within the `SidePanel` component as a child. Use in conjunction with `useSidePanel`'s `controlProps`, otherwise it does not come with explicit `onClick` handlers.
lychyi marked this conversation as resolved.
Show resolved Hide resolved

> This is a standard Canvas Kit [`IconButton`](https://github.com/Workday/canvas-kit/tree/master/modules/button/react#iconbutton) and will accept those props.

> **Important**: For accessibility purposes, it must be the first focusable element. We recommend that you keep it as the first child of `SidePanel`.
lychyi marked this conversation as resolved.
Show resolved Hide resolved

## Component Props

### Required

> None

### Optional

#### `as: React.ElementType`
> The element the side panel will render as.

Default: `'section'`

#### `collapsedWidth: number | string`
> The width of the component (in `px` if it's a `number`) when it is collapsed.

Default: `64`

#### `expanded: boolean`
> If true, sets the expanded state of the side panel

Default: `false`

#### `expandedWidth: number | string`
> The width of the component (in `px` if it's a `number`) when it is expanded.

Default: `320`

#### `origin: 'left' | 'right'`
> Which side the side panel is meant to originate from.

Default: `'left'`

#### `onExpandedChange: (expanded?: boolean) => void`
> The function called when the side panel's `expanded` state changes. States like `'collapsing'` and `'expanding'` are tracked in another callback: `onStateChange`
lychyi marked this conversation as resolved.
Show resolved Hide resolved

#### `onStateTransition: (state?: SidePanelTransitionStates) => void`
> The function called when the side panel is transitioning between states. Use this to track when the side panel is animating between 'collapsed', 'collapsing', 'expanded', and 'expanding' states. This can be particularly helpful if child components need to react specifically to these states.
lychyi marked this conversation as resolved.
Show resolved Hide resolved

#### `variant: SidePanelVariant`
> The style variant of the side panel. 'standard' is with a `soap100` background, no depth. 'alternate' is a `frenchVanilla100` background with a level 3 depth.

Default: `'standard'`

6 changes: 6 additions & 0 deletions modules/_labs/side-panel/react/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import SidePanel from './lib/SidePanel';
import {useSidePanel} from './lib/hooks';

export default SidePanel;
export {SidePanel, useSidePanel};
export * from './lib/SidePanel';
Loading