Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-enable postcss for storybook builds to transpile svg-load #919

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

anicholls
Copy link
Contributor

Summary

In #897 I inadvertently disabled postcss transpilation, but only for storybook builds. It didn't show up until we tried to upload the built storybook to chromatic. The problem came from switching from a custom webpack rule to @storybook/preset-css. I've gone back to a custom rule (based on the simple preset) and it should fix the issue.

@cypress
Copy link

cypress bot commented Nov 25, 2020



Test summary

560 0 1 0


Run details

Project canvas-kit
Status Passed
Commit 58b454a ℹ️
Started Nov 25, 2020 10:25 PM
Ended Nov 25, 2020 10:32 PM
Duration 06:27 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@anicholls anicholls merged commit ec9b7d8 into Workday:master Nov 25, 2020
@anicholls anicholls deleted the re-add-postcss branch November 25, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant