-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix create component scripts #929
Conversation
/// <reference path="${rootPath}/../typings.d.ts" /> | ||
/** @jsx jsx */ | ||
import {jsx} from '@emotion/core'; | ||
import {StaticStates} from '@workday/canvas-kit-labs-react-core'; | ||
import {ComponentStatesTable, permutateProps, withSnapshotsEnabled} from '../../../../utils/storybook'; | ||
import {ComponentStatesTable, permutateProps, withSnapshotsEnabled} from '../../../../${unstable ? '../' : ''}utils/storybook'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust path to storybook utils based on whether or not this is a Labs module. Labs modules sit one level deeper in the folder structure since they're placed in the _labs
folder alongside the non-Labs modules.
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
75e909f (upstream/master, master) feat(common): Add useIsRTL hook to common module (Workday#971) 771a215 fix(tabs): Remove event.preventDefault from TabList (Workday#969) b7f87a1 Update Pagination component (Workday#954) 91acada Roll back to `pull_request` 69cc4b4 fix: Add crossorigin to font preloads (Workday#967) ea5dbd8 ci: Use pull_request_target in GH Actions 159da10 docs: Fix Story names and extra imports (Workday#966) 8dcc951 docs: Improve documentation (Workday#964) 221fa1c feat: Add closeButtonAriaLabel to Modal Component (Workday#959) 339be74 ci: Remove jest code-coverage threshold (Workday#957) 6491da3 docs: Add compound component doc (Workday#937) d7ec090 feat: Add window config option to inherit or override mono font family (Workday#916) 968130a chore: Bump ini from 1.3.5 to 1.3.7 (Workday#931) 27504a1 feat(skeleton): Add option for different skeleton colors (Workday#939) 3ba2da8 chore: Update @workday/canvas-system-icons-web dependency (Workday#940) 37cfd15 Add custom limit to CountBadge (Workday#935) 3634149 chore(form-field): Update FormField Readme (Workday#930) 42b9235 fix: Fix create component scripts (Workday#929) b3ee342 docs: Standardize README badges for Labs components (Workday#928)
Summary
Our createComponent script was bombing out with
TypeError: exec is not a function
due to incorrectrequire
statements forexec
. Originally,node-cmd
was used to run commands, but it was removed as a dependency in favor ofexec
in #908. However, therequire
statements in the createComponent scripts weren't updated to useexec
until #912. This PR adds the necessary destructuring to get thoserequire
statements working.It also fixes a path issue with the
stories_VisualTesting
template.