Add custom limit to CountBadge #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanbsmith
added
enhancement
project-bot
bot
moved this from In Progress
to Needs Review
in Current Sprint (7/20 - 8/9)
|
LGTM 👍 |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
alanbsmith
commented
Jan 7, 2021
|
|
||
| const formattedCount = count < 1000 ? `${count}` : '999+'; | ||
| const formattedCount = count < limit ? `${count}` : `${limit - 1}+`; |
There was a problem hiding this comment.
Note: The math here won't work if numbers are negative. haha
We could validate the limit here "needs to be greater than 0" or something like that, but I kind of want to keep the badge as dumb as possible.
NicholasBoll
approved these changes
Jan 7, 2021
alanbsmith
added a commit
to alanbsmith/canvas-kit
that referenced
this pull request
Feb 16, 2021
75e909f (upstream/master, master) feat(common): Add useIsRTL hook to common module (Workday#971) 771a215 fix(tabs): Remove event.preventDefault from TabList (Workday#969) b7f87a1 Update Pagination component (Workday#954) 91acada Roll back to `pull_request` 69cc4b4 fix: Add crossorigin to font preloads (Workday#967) ea5dbd8 ci: Use pull_request_target in GH Actions 159da10 docs: Fix Story names and extra imports (Workday#966) 8dcc951 docs: Improve documentation (Workday#964) 221fa1c feat: Add closeButtonAriaLabel to Modal Component (Workday#959) 339be74 ci: Remove jest code-coverage threshold (Workday#957) 6491da3 docs: Add compound component doc (Workday#937) d7ec090 feat: Add window config option to inherit or override mono font family (Workday#916) 968130a chore: Bump ini from 1.3.5 to 1.3.7 (Workday#931) 27504a1 feat(skeleton): Add option for different skeleton colors (Workday#939) 3ba2da8 chore: Update @workday/canvas-system-icons-web dependency (Workday#940) 37cfd15 Add custom limit to CountBadge (Workday#935) 3634149 chore(form-field): Update FormField Readme (Workday#930) 42b9235 fix: Fix create component scripts (Workday#929) b3ee342 docs: Standardize README badges for Labs components (Workday#928)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #936
This PR adds functionality for custom limits to format the displayed count in
CountBadge. I also added a test and updated the docs.Checklist
yarn testpassespackage.jsoncanvas-kit-reactand/orcanvas-kit-cssuniversal modules, ifapplicable
Additional References