Skip to content

Commit

Permalink
Merge pull request #59 from Workflomics/improve-maintainability
Browse files Browse the repository at this point in the history
Improve maintainability
  • Loading branch information
kretep committed Mar 11, 2024
2 parents 88919dd + 824988b commit 4409e65
Show file tree
Hide file tree
Showing 10 changed files with 56 additions and 21 deletions.
30 changes: 30 additions & 0 deletions .github/workflows/build-frontend.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Build Frontend

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [14.x]

steps:
- uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Install Dependencies
run: npm install

- name: Build
run: npm run build
16 changes: 12 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
# Workflomics: A Workflow Benchmarking Platform (front end)
<img src="https://raw.githubusercontent.com/Workflomics/.github/main/WORKFLOMICS_logo_small.jpg" alt="logo" width=60%/>

# Workflomics: A Workflow Benchmarking Platform


| Badges | |
|:------------------------:|------------------------------------------------------------------------------------------------------------------------------|
| **Packages and Releases** | [![Latest release](https://img.shields.io/github/release/workflomics/workflomics-frontend.svg)](https://github.com/sanctuuary/APE/releases/latest) [![Static Badge](https://img.shields.io/badge/RSD-Workflomics-workflomics)](https://research-software-directory.org/software/workflomics) |
| **Build Status** | [![Build Frontend](https://github.com/Workflomics/workflomics-frontend/actions/workflows/build-frontend.yaml/badge.svg)](https://github.com/Workflomics/workflomics-frontend/actions/workflows/build-frontend.yaml) |
| **Documentation Status** | [![Documentation Status](https://readthedocs.org/projects/workflomics/badge/?version=latest)](https://workflomics.readthedocs.io/en/latest/?badge=latest) |
| **DOI** | [![DOI](https://zenodo.org/badge/594054560.svg)](https://zenodo.org/doi/10.5281/zenodo.10047136) |
| **License** | ![GitHub](https://img.shields.io/github/license/workflomics/workflomics-frontend) |

[![Documentation Status](https://readthedocs.org/projects/workflomics/badge/?version=latest)](https://workflomics.readthedocs.io/en/latest/?badge=latest)
[![DOI](https://zenodo.org/badge/594054560.svg)](https://zenodo.org/doi/10.5281/zenodo.10047136)
[![License](https://img.shields.io/badge/License-Apache_2.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)

## Project goal

Expand Down
14 changes: 9 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions src/components/Footer.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import * as React from 'react';

interface Props {
}

export function Footer({ }: Props) {
export function Footer() {
return (
<div>
<footer className="footer px-10 py-4 border-t bg-base-200 text-base-content border-base-300">
Expand Down
2 changes: 1 addition & 1 deletion src/components/HomeBox.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Link, Route } from 'react-router-dom';
import { Link } from 'react-router-dom';

interface Props {
/** Title of the menu option. */
Expand Down
2 changes: 0 additions & 2 deletions src/components/explore/ExplorationProgress.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { Link } from 'react-router-dom';

interface Props {
index: number;
}
Expand Down
1 change: 0 additions & 1 deletion src/components/explore/InputOutputSelection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const InputsOutputSelection: React.FC<InputsOutputSelectionProps> = observer(({
{
Object.values(dataTaxonomy).map((paramClass) => {
// try {
const temp = parameterTuple;
return (
<TreeSelectionBox
key={paramClass.id}
Expand Down
2 changes: 1 addition & 1 deletion src/components/explore/InputsOutputs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useStore } from '../../store';
import { InputsOutputSelection } from './InputOutputSelection';
import { Link } from 'react-router-dom';
import { runInAction } from 'mobx';
import { ApeTaxTuple, TaxonomyClass } from '../../stores/TaxStore';
import { ApeTaxTuple } from '../../stores/TaxStore';


const InputsOutputs: React.FC<any> = observer((props) => {
Expand Down
1 change: 0 additions & 1 deletion src/components/explore/WorkflowConstraints.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const WorkflowConstraints: React.FC<any> = observer((props) => {
);
let { taxStore } = useStore();
const allToolsTax: ApeTaxTuple = taxStore.availableToolTax;
const allDataTax: ApeTaxTuple = taxStore.availableDataTax;

React.useEffect(() => {
if (workflowConfig.domain !== undefined) {
Expand Down
5 changes: 2 additions & 3 deletions src/stores/ExploreDataStore.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { makeAutoObservable } from "mobx";
import { ConstraintInstance, WorkflowConfig, WorkflowSolution, isTaxParameterComplete as isTaxParameterComplete } from "./WorkflowTypes";
import { ConstraintInstance, WorkflowConfig, WorkflowSolution, isTaxParameterComplete } from "./WorkflowTypes";
import { makePersistable } from "mobx-persist-store";
import { ApeTaxTuple } from "./TaxStore";

Expand Down Expand Up @@ -76,7 +76,7 @@ export class ExploreDataStore {
* @returns JSON representation of the constraints
*/
constraintsToJSON(allConstraints: ConstraintInstance[]) {
const newConst = allConstraints.filter(constraint => constraint.id != "")
const newConst = allConstraints.filter(constraint => constraint.id !== "")
.map((constraint) => {
return {
"constraintid": constraint!.id,
Expand Down Expand Up @@ -162,7 +162,6 @@ export class ExploreDataStore {
}

runSynthesis(config: WorkflowConfig) {
const domainConfig = config.domain;
const configJson: any = this.configToJSON(config);

this.isGenerating = true;
Expand Down

0 comments on commit 4409e65

Please sign in to comment.