Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-827 Add line-length option to format task. #18

Merged
merged 1 commit into from
Aug 17, 2015
Merged

Conversation

evanweible-wf
Copy link
Contributor

Issue

Changes

Source:

  • Add option to configure line length for dart formatter

Tests:

  • n/a

Areas of Regression

  • default usage of dart_dev format task

Testing

  • ddev format --check should find no necessary changes
  • ddev format --check -l 150 should find quite a few necessary changes

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
fyi: @jayudey-wf

@maxwellpeterson-wf
Copy link
Member

+1 :)

@trentgrover-wf
Copy link
Contributor

+1
@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title Add line-length option to format task. CP-827 Add line-length option to format task. Aug 17, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • verified that line length was being properly applied during format task and that default usage remained un-affected
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 17, 2015
CP-827 Add line-length option to format task.
@jayudey-wf jayudey-wf merged commit 2d7205c into master Aug 17, 2015
@trentgrover-wf trentgrover-wf deleted the fmt-line-length branch August 19, 2015 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants