Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cachebust feature #17

Closed
wants to merge 2 commits into from
Closed

Conversation

FaisalAbid
Copy link

Related (and dependent) to my previous pull request, but this enables auto cache busting by passing in

bust_cache: true
bust_cache_key: "dartcache"

into the transformer arguments in pubspec.yaml.

bust_cache_key is optional.

@sethladd
Copy link
Contributor

I'd love to merge this and then cut a 1.0. Can you please fix this and rebase?

@sethladd sethladd mentioned this pull request Sep 28, 2015
@greglittlefield-wf
Copy link
Collaborator

@FaisalAbid Ah, sorry to conflict with this work!

What do you think about an approach that makes use of Uri.parse? That may be more robust than the regex I wrote or manual String splitting.

@FaisalAbid
Copy link
Author

Hey, yea Uri.parse would be better. I'll clean this up tonight

@trentgrover-wf
Copy link

@greglittlefield-wf
@FaisalAbid
shall we get this cleaned up and reviewed?

@FaisalAbid
Copy link
Author

yea totally this needs to be done. My tonight never happened :P I'll try to take a look at it this weekend.

@dustinlessard-wf
Copy link

This is a nice addition, but hasn't been touched in quite some time. For now, we're going to close this pr but remain committed to assisting in any way possible, should this pr get reopened and the merge conflicts resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants