AF-2994 Rem sensor async mount #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de a component's render
…ty to aid in testing
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
| Element _changeSensorMountNode; | ||
| @visibleForTesting | ||
| Element get changeSensorMountNode => _changeSensorMountNode; | ||
|
|
||
| void _initRemChangeSensor() { |
There was a problem hiding this comment.
Changes in this PR are best viewed with whitespace-agnostic diffs: https://github.com/Workiva/over_react/pull/197/files?w=1
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 94.53% 94.59% +0.06%
==========================================
Files 34 34
Lines 1645 1661 +16
==========================================
+ Hits 1555 1571 +16
Misses 90 90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Initializing the rem-change-detecting ResizeSensor synchronously can cause React warnings and get React into a bad state if this happens inside a component's
render.This can happen when
toRemis used for the first time inside a component render method, as is case in w_context_menu's tests in master with the latest over_react.How it was fixed:
Testing suggestions:
ddev testPotential areas of regression:
Rem sensor