Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FED-466: Fix console logs that require formatting #52

Merged
merged 14 commits into from
Oct 20, 2022
Merged

FED-466: Fix console logs that require formatting #52

merged 14 commits into from
Oct 20, 2022

Commits on Oct 14, 2022

  1. fix console logs that require formatting

    @kealjones-wk
    kealjones-wk committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    aa96e2f View commit details
    Browse the repository at this point in the history

  2. add 1 test for formatter :P

    @kealjones-wk
    kealjones-wk committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    c6fde52 View commit details
    Browse the repository at this point in the history

  3. fix json stringify

    @kealjones-wk
    kealjones-wk committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    8f7b9d4 View commit details
    Browse the repository at this point in the history

  4. add more situations to the formatter test

    @kealjones-wk
    kealjones-wk committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    19b2de9 View commit details
    Browse the repository at this point in the history

  5. address gregs feedback

    @kealjones-wk
    kealjones-wk committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    5eeb3a0 View commit details
    Browse the repository at this point in the history

  6. add exact number of args test

    @kealjones-wk
    kealjones-wk committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6790c0d View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. address feedback

    @kealjones-wk
    kealjones-wk committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    800eeb3 View commit details
    Browse the repository at this point in the history

  2. add doc comment, and add all options from spec

    @kealjones-wk
    kealjones-wk committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    2e3d986 View commit details
    Browse the repository at this point in the history

  3. change console getter to final in function

    @kealjones-wk
    kealjones-wk committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    cfc5f88 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. fix typing

    @kealjones-wk
    kealjones-wk committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    2b39903 View commit details
    Browse the repository at this point in the history

  2. fix javascript function call for dart2js 

    - itz dumb and i dont like it.
    @kealjones-wk
    kealjones-wk committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c7beb86 View commit details
    Browse the repository at this point in the history

  3. add // @Dart = 2.7 to head of formatter file

    @kealjones-wk
    kealjones-wk committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    80acd97 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into spike-fed-466

    @kealjones-wk
    kealjones-wk committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    3990a38 View commit details
    Browse the repository at this point in the history

  5. use the this argument for jsfunctionapply

    @kealjones-wk
    kealjones-wk committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    b814c35 View commit details
    Browse the repository at this point in the history