Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed details view #100

Merged
merged 8 commits into from
Sep 1, 2015
Merged

Tabbed details view #100

merged 8 commits into from
Sep 1, 2015

Conversation

kshepard
Copy link
Member

@kshepard kshepard commented Sep 1, 2015

Will add remaining tests for controllers/directives before merging.

This is the behavior that existed before the refactor.
Without it, if you refresh the page, your parameters are
always reset to the first items in the lists.
@moradology
Copy link
Contributor

Looks like this is maybe a good idea for the textarea <pre> elements: https://css-tricks.com/snippets/css/make-pre-text-wrap/

@moradology
Copy link
Contributor

This looks really good; +1 after trying to get that text to wrap

@kshepard
Copy link
Member Author

kshepard commented Sep 1, 2015

Cool, good call on the text wrap. Didn't have any text long enough in my tests to notice it didn't wrap.

@moradology
Copy link
Contributor

Yeah, and pre is a really obscure tag

kshepard added a commit that referenced this pull request Sep 1, 2015
@kshepard kshepard merged commit 90b7f03 into develop Sep 1, 2015
@kshepard kshepard deleted the feature/tabbed-details branch September 1, 2015 19:37
@kshepard kshepard restored the feature/tabbed-details branch September 1, 2015 19:37
@kshepard kshepard deleted the feature/tabbed-details branch September 1, 2015 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants