fix the regex that did not detect items with nothing in []

WorldBrain · Apr 4, 2024 · 0bdeba9 · 0bdeba9
1 parent d76320c
commit 0bdeba9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/personal-cloud/background/handle-incoming-data.ts b/src/personal-cloud/background/handle-incoming-data.ts
@@ -368,12 +368,12 @@ function maybeReplaceAnnotCommentImages(
     imageSupportBG: ImageSupportBackground,
 ): Promise<void>[] {
     // Should match the data URL part of a markdown string containing something like this: "![alt text](data:image/png;base64,asdafasf)"
-    const dataUrlExtractRegexp = /!\[[\w|\s|\.|\!|\-|\?|=]*\]\((data:image\/(png|jpeg);base64,[\w|\+|\/|=]+)\)/g
+    const dataUrlExtractRegexp = /!\[.*?\]\((data:image\/(?:png|jpeg|gif);base64,[\w+/=]+)\)/g
     // Most comments should exit here
     if (!dataUrlExtractRegexp.test(annotation.comment)) {
         return []
     }
-
+    dataUrlExtractRegexp.lastIndex = 0 // Reset lastIndex to 0
     const matches = annotation.comment.matchAll(dataUrlExtractRegexp)
     const dataUrlToImageId = new Map<string, string>()
     const imageUploadPromises: Promise<void>[] = []

diff --git a/src/search-injection/components/youtubeActionBar.tsx b/src/search-injection/components/youtubeActionBar.tsx
@@ -105,7 +105,6 @@ export default class YoutubeButtonMenu extends React.Component<Props, State> {
         }
         browser.runtime.onMessage.addListener((message) => {
             if (message.type === 'URL_CHANGE') {
-                console.log('URL_CHANGE', message.url)
                 this.getYoutubeVideoDuration()
             }
         })
@@ -120,7 +119,6 @@ export default class YoutubeButtonMenu extends React.Component<Props, State> {
         if (video) {
             let duration = video.duration
 
-            console.log('duration', duration)
             this.setState({
                 videoDuration: duration,
             })
@@ -200,7 +198,6 @@ export default class YoutubeButtonMenu extends React.Component<Props, State> {
         let timestampToSend = null
 
         if (event.shiftKey) {
-            console.log('Shift key is pressed during click')
             const range = this.calculateRangeInSeconds(
                 this.state.videoDuration,
                 from,