Skip to content

Commit

Permalink
Patch @firebase/auth to not add any <script> tags to the DOM
Browse files Browse the repository at this point in the history
- We got rejected from the Chrome store because of this.
- It shouldn't have even worked anyway as it assumes DOM APIs which we no longer have in the BG SW
  • Loading branch information
poltak committed Mar 26, 2024
1 parent 0645e67 commit 360ad69
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions patches/@firebase+auth+0.20.6.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
diff --git a/node_modules/@firebase/auth/dist/esm2017/index-6bd8d405.js b/node_modules/@firebase/auth/dist/esm2017/index-6bd8d405.js
index 9abd2b3..294cc95 100644
--- a/node_modules/@firebase/auth/dist/esm2017/index-6bd8d405.js
+++ b/node_modules/@firebase/auth/dist/esm2017/index-6bd8d405.js
@@ -8851,8 +8851,9 @@ function loadGapi(auth) {
}
};
// Load GApi loader.
- return _loadJS(`https://apis.google.com/js/api.js?onload=${cbName}`)
- .catch(e => reject(e));
+ // Skip this as it won't work in our BG SW
+ // return _loadJS(`https://apis.google.com/js/api.js?onload=${cbName}`)
+ // .catch(e => reject(e));
}
}).catch(error => {
// Reset cached promise to allow for retrial.

0 comments on commit 360ad69

Please sign in to comment.