Also rm ext detection el from DOM on CS teardown

WorldBrain · Apr 9, 2024 · bd23649 · bd23649
1 parent 0bd4d53
commit bd23649
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/external/@worldbrain/memex-common b/external/@worldbrain/memex-common
diff --git a/src/content-scripts/content_script/global.ts b/src/content-scripts/content_script/global.ts
@@ -1,6 +1,9 @@
 import { EventEmitter } from 'events'
 import type { ContentIdentifier } from '@worldbrain/memex-common/lib/page-indexing/types'
-import { injectMemexExtDetectionEl } from '@worldbrain/memex-common/lib/common-ui/utils/content-script'
+import {
+    injectMemexExtDetectionEl,
+    removeMemexExtDetectionEl,
+} from '@worldbrain/memex-common/lib/common-ui/utils/content-script'
 import {
     MemexOpenLinkDetail,
     MemexRequestHandledDetail,
@@ -1162,6 +1165,7 @@ export async function main(
             })(window.getSelection(), shouldShare, shouldCopyLink),
         removeHighlights: async () => highlightRenderer.resetHighlightsStyles(),
         teardownContentScripts: async () => {
+            removeMemexExtDetectionEl()
             await inPageUI.hideHighlights()
             await inPageUI.hideSidebar()
             await inPageUI.removeRibbon()