Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"0 Cases" in WHO COVID-19 dashboard stats #1724

Closed
2 tasks done
msaini888 opened this issue Nov 9, 2020 · 0 comments · Fixed by #1887
Closed
2 tasks done

"0 Cases" in WHO COVID-19 dashboard stats #1724

msaini888 opened this issue Nov 9, 2020 · 0 comments · Fixed by #1887
Labels
bug Something isn't working case-stats User-facing dashboards, graphs, numbers of COVID-19 statistics client-ui Client user interface needs:triage New issue that needs triage P2 "Nice to have" - shipping next version without this will not have a major impact
Milestone
v1.0 - Nigeria

Comments

@msaini888
Copy link

msaini888 commented Nov 9, 2020 •
edited by brunobowden
Loading

Summary

The data feed from the WHO dashboard reports "0 cases" for multiple countries. The app needs to distinguish between two cases:

  • Cases are legitimately zero
  • The data is wrong and doesn't have data for today

Possible Fix

Server side fix to put it under more control

  • If today's cases > 0 => treat all data as valid
  • If today's cases == 0
    • If yesterday's cases == 0 => treat all data as valid
    • If yesterday's cases > 0 => drop today's data as it's possibly inaccurate

So when a country first drops to zero cases, it won't display that immediately but take an extra day (it would just show the data up until yesterday). Hardly ideal but better than showing incorrect data for several countries.

Further Info

Reproduction Steps

Steps to reproduce the behavior:

  1. Launch the app and complete onboarding journey and select country as US.
  2. Tap on Stats in the footer section of the home screen.
  3. Observe the daily stats

Expected Behavior
Correct Daily Stats count should be displayed to the user.

Actual Behavior
Incorrect Daily Stats count is displayed to the user as 0.

  • Device: Huawei Honor 7c
  • OS: Android 8.0
  • App Version: 0.14.0 (25)

Additional Context

Our App is fetching stats from the official WHO dashboard but even the WHO dashboard is showing incorrect daily stats count for US for the past 24 hours.
We should have a fix to check the data which is being fetched from the WHO dashboard.

Screenshots
0_daily_cases_US

Checklist:
@msaini888 msaini888 added needs:triage New issue that needs triage source:public Issues created by the public bug Something isn't working case-stats User-facing dashboards, graphs, numbers of COVID-19 statistics client-ui Client user interface P2 "Nice to have" - shipping next version without this will not have a major impact and removed source:public Issues created by the public labels Nov 9, 2020
@msaini888 msaini888 mentioned this issue Nov 9, 2020
Open
2 tasks
@brunobowden brunobowden changed the title Daily Case Count being incorrectly displayed as 0 on Stats Screen "0 Cases" in WHO COVID-19 dashboard stats Nov 9, 2020
@brunobowden brunobowden added this to the v1.0 - Nigeria milestone Nov 9, 2020
This was referenced Dec 26, 2020
Open
Merged
brunobowden added a commit to brunobowden/app that referenced this issue Dec 27, 2020
@brunobowden
Stats Fix - Partial Last Day
bf01921 
WHO dashboard stats are updated throughout the day. Some countries
may report 0 for daily cases and deaths. The ArcGIS data response can't
distinguish between "zero cases" and "no data reported yet".
So this heuristic deals with that:
- Global Stats: sum all stats, not just partial stats on last day
- Country Stats: drop last day when likely "no data reported yet"

Fixes WorldHealthOrganization#1724
Fixes WorldHealthOrganization#1876
brunobowden added a commit that referenced this issue Dec 27, 2020
@brunobowden
Stats Fix - Partial Last Day (#1887)
241589b 
* Stats Fix - Partial Last Day

WHO dashboard stats are updated throughout the day. Some countries
may report 0 for daily cases and deaths. The ArcGIS data response can't
distinguish between "zero cases" and "no data reported yet".
So this heuristic deals with that:
- Global Stats: sum all stats, not just partial stats on last day
- Country Stats: drop last day when likely "no data reported yet"

- Specifically test partial data for global stats correction
- More explanation around test case data

Fixes #1724
Fixes #1876
@brunobowden brunobowden modified the milestones: vGlobal, v1.0 - Nigeria Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working case-stats User-facing dashboards, graphs, numbers of COVID-19 statistics client-ui Client user interface needs:triage New issue that needs triage P2 "Nice to have" - shipping next version without this will not have a major impact
Projects
None yet
Milestone
v1.0 - Nigeria
Development

Successfully merging a pull request may close this issue.

Stats Fix - Partial Last Day brunobowden/app
2 participants
@brunobowden @msaini888