Stats Fix - Partial Last Day #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobowden
added
source:who
WHO dashboard stats are updated throughout the day. Some countries may report 0 for daily cases and deaths. The ArcGIS data response can't distinguish between "zero cases" and "no data reported yet". So this heuristic deals with that: - Global Stats: sum all stats, not just partial stats on last day - Country Stats: drop last day when likely "no data reported yet" Fixes WorldHealthOrganization#1724 Fixes WorldHealthOrganization#1876
brunobowden
force-pushed
the
global-stats-partial-day-fix
branch
from
d662d7f
to
bf01921
Compare
server/appengine/src/main/java/who/RefreshCaseStatsServlet.java
Outdated
Show resolved
Hide resolved
- Specifically test partial data for global stats correction - More explanation around test case data
matthewblain
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHO dashboard stats are updated throughout the day. Some countries
may report 0 for daily cases and deaths. The ArcGIS data response can't
distinguish between "zero cases" and "no data reported yet".
So this heuristic deals with that:
Fixes #1724
Fixes #1876
How did you test the change?
curlto a dev App Engine serverChecklist: