Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues #196

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix CI issues #196

merged 1 commit into from
Apr 8, 2019

Conversation

astrofrog
Copy link
Member

This is just an experimental PR to try different things to fix the CI

@pkgw
Copy link
Contributor

pkgw commented Apr 5, 2019

No dice, it looks like ...

@astrofrog astrofrog force-pushed the fix-ci branch 2 times, most recently from 9bce286 to 8894a45 Compare April 8, 2019 10:12
@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ea2d404). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #196   +/-   ##
=========================================
  Coverage          ?   56.79%           
=========================================
  Files             ?       23           
  Lines             ?     1567           
  Branches          ?        0           
=========================================
  Hits              ?      890           
  Misses            ?      677           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2d404...8efd486. Read the comment docs.

…issue with loadFits affecting the widget subsequently and causing center_on_coordinates to not work correctly.
@astrofrog
Copy link
Member Author

Ok so I haven't yet figured out a proper fix, but the summary of the issue is that somehow, after the loadFits call, the widget isn't quite reset to its original state, and changes to e.g. the background/foreground or the coordinates don't actually have any effect, so the images in test_full are just with the black background set in the image layer tests. For now I'll fix the CI by simply running the Image tests with an isolated Qt widget.

@astrofrog astrofrog changed the title WIP: Investigate CI issues Fix CI issues Apr 8, 2019
@astrofrog astrofrog merged commit bea8b0c into WorldWideTelescope:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants